Debug output with Python 3.11 could be improved to match 3.10

[megholm]

• bleak version: 0.20.2
• Python version: 3.11.3
• Operating System: Windows
• BlueZ version (bluetoothctl -v) in case of Linux:

Description

With Python 3.10.x some lines looked like this:

10:36:52.675 [07396] bleak.ba: [D] session_status_changed_event_handler: id: <_bleak_winrt_Windows_Devices_Bluetooth.BluetoothDeviceId object at 0x000001976F8C8A70>, error: BluetoothError.SUCCESS, status: GattSessionStatus.ACTIVE
 10:36:56.827 [07396] bleak.ba: [D] session_status_changed_event_handler: id: <_bleak_winrt_Windows_Devices_Bluetooth.BluetoothDeviceId object at 0x000001976F8C8C50>, error: BluetoothError.SUCCESS, status: GattSessionStatus.CLOSED

With Python 3.11.x the str(IntEnum) output has changed and this lines become:

 11:34:27.057 [04408] bleak.ba: [D] session_status_changed_event_handler: id: BluetoothLE#BluetoothLEe0:d0:45:43:2e:b0-34:25:b4:a0:b8:0f, error: 0, status: 1
 11:34:31.595 [28732] bleak.ba: [D] session_status_changed_event_handler: id: BluetoothLE#BluetoothLEe0:d0:45:43:2e:b0-34:25:b4:a0:b8:0f, error: 0, status: 0

(Look at error- and status-values).

Consider just adding ".name" to the logger-line:

        def session_status_changed_event_handler(
            sender: GattSession, args: GattSessionStatusChangedEventArgs
        ):
            logger.debug(
                "session_status_changed_event_handler: id: %s, error: %s, status: %s",
                sender.device_id.id,
                args.error.name,
                args.status.name,
            )
            loop.call_soon_threadsafe(handle_session_status_changed, args)

[dlech]

Perhaps even better would be to change %s to %r so we get the repr which shows both values instead of one or the other?

[megholm]

Sure. Anything but the raw integer values... Go ahead! :-)

…

On Thu, Apr 20, 2023, 16:26 David Lechner ***@***.***> wrote: Perhaps even better would be to change %s to %r so we get the repr which shows both values instead of one or the other? — Reply to this email directly, view it on GitHub <#1284 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABKXZUE7E2AS7QIU5O3ZAPDXCFBQRANCNFSM6AAAAAAXFJMTLY> . You are receiving this because you authored the thread.Message ID: ***@***.***>