Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect mypy diagnosis of Unpack[ExtraArgs]. #1488

Merged
merged 1 commit into from
Dec 30, 2023
Merged

fix: incorrect mypy diagnosis of Unpack[ExtraArgs]. #1488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ Contributors
* Edward Betts <edward@4angle.com>
* Robbe Gaeremynck <robbe.gaeremynck@outlook.com>
* David Johansen <davejohansen@gmail.com>
* JP Hutchins <jphutchins@gmail.com>

Sponsors
--------
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ Changed
Fixed
-----
* Fixed BlueZ version in passive scanning error message. Fixes #1433.
* Fixed mypy requiring ``Unpack[ExtraArgs]`` that were intended to be optional. Fixes #1487.

`0.21.1`_ (2023-09-08)
======================
Expand Down
2 changes: 1 addition & 1 deletion bleak/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ async def advertisement_data(
finally:
unregister_callback()

class ExtraArgs(TypedDict):
class ExtraArgs(TypedDict, total=False):
"""
Keyword args from :class:`~bleak.BleakScanner` that can be passed to
other convenience methods.
Expand Down
Loading