More typehints #1514
Merged
More typehints #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siecje
commented
Feb 15, 2024
bleak/backends/service.py
Outdated
| @@ -21,10 +21,10 @@ | |||
| class BleakGATTService(abc.ABC): | |||
| """Interface for the Bleak representation of a GATT Service.""" | |||
|
|
|||
| def __init__(self, obj): | |||
| def __init__(self, obj) -> None: | |||
There was a problem hiding this comment.
I saw that but what are the possible types? Can we list them?
There was a problem hiding this comment.
They are backend-specific so we can't because it would cause import errors. Also, this is considered internal API, so I don't want people expecting any specific stable type.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.