Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use predefined service uuids #706

Merged
merged 1 commit into from
Dec 30, 2021
Merged

Use predefined service uuids #706

merged 1 commit into from
Dec 30, 2021

Conversation

mkoderer
Copy link
Contributor

On macos the service_uuids need to be filled. Main issue for
beginners is to retrieve some valid uuids. Instead of using an
external tool like nRF we could use predefined ones in bleak/uuids.

Implementation works with 128bit and 16bit UUIDs.

Related-to #635

Signed-off-by: Marc Koderer marc@koderer.com

dlech
dlech reviewed Dec 30, 2021
View reviewed changes
Copy link
Collaborator

@dlech dlech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great idea! Can we add some comments about why this is needed?

I found one potential problem. The rest of my comments are bike-shedding, so feel free to ignore if you don't think they make it better.

examples/detection_callback.py Outdated Show resolved Hide resolved
examples/detection_callback.py Outdated Show resolved Hide resolved
examples/detection_callback.py Show resolved Hide resolved
examples/detection_callback.py Outdated Show resolved Hide resolved
@dlech
Copy link
Collaborator

dlech commented Dec 30, 2021

Thanks for updating. The black code formatter is complaining about one line. Maybe there is a trailing newline or a tab instead of spaces?

@mkoderer
Use predefined service uuids
7d92ff6 
On macos the service_uuids need to be filled. Main issue for
beginners is to retrieve some valid uuids. Instead of using an
external tool like nRF we could use predefined ones in bleak/uuids.

Implementation works with 128bit and 16bit UUIDs.

Related-to hbldh#635

Signed-off-by: Marc Koderer <marc@koderer.com>
@mkoderer
Copy link
Contributor Author

Should pass now

@dlech dlech merged commit 156e8af into hbldh:develop Dec 30, 2021
@dlech
Copy link
Collaborator

dlech commented Dec 30, 2021

Thanks!

@hbldh
Copy link
Owner

hbldh commented Dec 30, 2021

Very good, thank you! This is an essential addition to the example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlech dlech dlech left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkoderer @dlech @hbldh