Cache service resolution on connect when using BlueZ/Dbus backend when requested #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will not work with devices that suffer from the issues described in #882. We need to wait for "ServicesResolved" after connect to ensure that BlueZ is not longer adding or removing service/characteristic/descriptor d-bus objects. I suppose we could make this opt-in for devices that are known to be well behaved (meaning they don't trigger the BlueZ bugs). |
dlech
reviewed
Aug 6, 2022
bdraco
force-pushed
the
bluez_service_cache
branch
2 times, most recently
from
aa82962 to
5e87ff9
Compare
bdraco
changed the title
bdraco
force-pushed
the
bluez_service_cache
branch
3 times, most recently
from
3c5c4fc to
f8e524c
Compare
|
I reworked it to be opt-in and renamed it to be |
…hen requested If the device was previously connected and we have the the service collection already built, it can be reused for the next connection if the device has not since been removed from the bus when the dangerous_use_bleak_cache flag is passed. For devices that connect and disconnect frequently this can make operations up to an magnitude faster once the first connection has been made and the device has not been removed from the bus since the last connection.
bdraco
force-pushed
the
bluez_service_cache
branch
from
f8e524c to
11d99d1
Compare
This was referenced Aug 7, 2022
bdraco
commented
Sep 5, 2022
dlech
reviewed
Sep 5, 2022
|
Thanks |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the device was previously connected and we have the
the service collection already built, it can
be reused for the next connection if the device has not
since been removed from the bus when the dangerous_use_bleak_cache
flag is passed.
For devices that connect and disconnect frequently this
can make operations up to an magnitude faster once
the first connection has been made and the device
has not been removed from the bus since the last
connection.
In testing this significantly reduced the time it took to execute operations on Ble devices. The goal is to be able to quickly operate Bluetooth locks (and other similar devices)