Expose QR code helper explicitly #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies making use of it without having access to a client instance.
Majsvaffla
force-pushed
the
generate-qr-code-util
branch
from
64dad4a
to
4913557
Compare
|
Yes, I see your point. I had it that way in the beginning, but felt that you probably always had the client available anyway so I could save users the extra import. Now I have been proven wrong. Can you move the generate method to utils.py instead of the base class file? Then I will merge it and release 1.0.1 soon after that. |
hbldh
requested changes
Apr 8, 2024
| @@ -83,3 +72,18 @@ def _create_payload( | |||
| if user_visible_data_format and user_visible_data_format == "simpleMarkdownV1": | |||
| data["userVisibleDataFormat"] = "simpleMarkdownV1" | |||
| return data | |||
|
|
|||
|
|
|||
| def generate_qr_code_content(qr_start_token: str, start_t: [float, datetime], qr_start_secret: str) -> str: | |||
|
This has now been released in version 1.0.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At work, we recently migrated to v1.0.0 of pybankid. The way our code is written makes it cumbersome to access the
generate_qr_code_contentstaticmethod of the client instance. These changes makes it possible to import that helper from the package top level, while keeping the staticmethod on the client class for backwards compatibility.