-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use builtin importlib.resources. #66
Conversation
Supporting Python >=3.9 does not require using the backport. Also, use joinpath() to simplify the retrival of the path+return pathlib.Path instead of str.
I had intended to keep compatibility to 3.7, but only test on >=3.9. This breaks that. But it is better to avoid that dependency, so lets go with this. |
Thanks! Hopefully most people have moved past 3.7 now :) |
This doesn't just break on Python 3.7 but also breaks with |
Yes. In that case I will look at a modification that enables use of 3.7 and forward. |
Since 3.8 was not part of CI i did not think it was supported. It is probably possible to avoid the error by using |
It's a bit of a catch-22 situation as |
See also issue #69 |
This should now be solved and is released in newly published version 1.2.0 on PyPI. |
Supporting Python >=3.9 does not require using the backport.
Also, use joinpath() to simplify the retrival of the path+return pathlib.Path instead of str.