Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summaries truncated indicator (dots) seems not work well with <!--more-->. #387

Closed
razonyang opened this issue Oct 9, 2023 · 3 comments · Fixed by #388 or #385
Closed

Summaries truncated indicator (dots) seems not work well with <!--more-->. #387

razonyang opened this issue Oct 9, 2023 · 3 comments · Fixed by #388 or #385
Labels
bug Something isn't working

Comments

@razonyang
Copy link
Member

i.e.

This module ships with an universal pagination template, which allows configuring by parameters, such as alignment, size and the number of siblings.

<!--more-->

image

I'd like to revert the #374 change, @TetraTheta what do you think?

@razonyang razonyang added the bug Something isn't working label Oct 9, 2023
@TetraTheta
Copy link
Contributor

If that hurts <!--more--> syntax, it should be reverted. So, yeah, it is OK to revert it.

I didn't tested my PR with <!--more--> so that would be my fault.

@razonyang
Copy link
Member Author

razonyang commented Oct 9, 2023

I replaced it with a read more button, it should be better for clients to continue reading and get better experience (no need to scroll up to find and click the title).

image

Could you do me a favor for translating the item read_more in Korean?

@TetraTheta
Copy link
Contributor

Could you do me a favor for translating the item read_more in Korean?

Done in #389

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants