Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TableTranslator , ScriptTranslator in Component #287

Merged
merged 16 commits into from
Feb 2, 2024

Conversation

shewer
Copy link
Contributor

@shewer shewer commented Oct 26, 2023

提供 設定開關 enable_.... , user_dict update 同 memory callback
table_translator
script_translator

Signed-off-by: shewer <shewer@gmail.com>
Signed-off-by: shewer <shewer@gmail.com>
Signed-off-by: shewer <shewer@gmail.com>
Signed-off-by: shewer <shewer@gmail.com>
Signed-off-by: shewer <shewer@gmail.com>
Signed-off-by: shewer <shewer@gmail.com>
Signed-off-by: shewer <shewer@gmail.com>
Signed-off-by: shewer <shewer@gmail.com>
Signed-off-by: shewer <shewer@gmail.com>
Signed-off-by: shewer <shewer@gmail.com>
Signed-off-by: shewer <shewer@gmail.com>
@mokapsing
Copy link

希望早点合入

Copy link
Owner

@hchunhui hchunhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这几个地方还需要再完善一下

src/lib/luatype_boost_optional.h Outdated Show resolved Hide resolved
: lua_(lua),
TableTranslator(ticket),
schema_id_(ticket.schema->schema_id()) {
memorize_callback_ = lua_->getglobal("___");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的 "___" 看起来不太对

Signed-off-by: shewer <shewer@gmail.com>
Signed-off-by: shewer <shewer@gmail.com>
@mokapsing
Copy link

这几个地方还需要再完善一下

再看下呢,非常需要这个功能

@hchunhui hchunhui merged commit a29897d into hchunhui:master Feb 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants