Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins with same repository name will collide #5

Open
samehkamaleldin opened this issue Dec 4, 2015 · 4 comments
Open

Plugins with same repository name will collide #5

samehkamaleldin opened this issue Dec 4, 2015 · 4 comments
Assignees
Labels
Milestone

Comments

@samehkamaleldin
Copy link
Collaborator

According to the current implementation, if we install to plugins with the same name but different developer they will overwrite each other.

What should be done about this ?

@YusufMohamed
Copy link
Collaborator

then we will have to write our own registry to prevent duplicates which will force developer to rename their plugin as we use npm implicitly .

possible solutions:

  • publish modules on npm as npm doesn't allow duplicates.
  • force developers to use their github name as a prefix. for example : YusufMohamed-plugin

@samehkamaleldin
Copy link
Collaborator Author

the npm strategy seems more appealing to me, but don't know if it's the best ?!

@YusufMohamed
Copy link
Collaborator

we can try. i will modify the code a bit but it will have the same functionality. should i proceed?

@samehkamaleldin
Copy link
Collaborator Author

Yes, please proceed.

On Fri, Dec 4, 2015 at 11:49 PM, Yusuf Mohamed notifications@github.com
wrote:

we can try. i will modify the code a bit but it will have the same
functionality. should i proceed?


Reply to this email directly or view it on GitHub
#5 (comment).

Sameh Kamaleldin

@samehkamaleldin samehkamaleldin added this to the v0.0.1 milestone Dec 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants