Feature/improved delayed execution #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcoles
force-pushed
the
feature/improved_delayed_execution
branch
from
f580663
to
c0a2548
Compare
hcoles
force-pushed
the
feature/improved_delayed_execution
branch
from
bcc62d9
to
4c86cb4
Compare
hcoles
force-pushed
the
feature/improved_delayed_execution
branch
from
856e9f7
to
376d386
Compare
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand detection of "delayed execution" code.
Fields now treated as holding delated code when type is genericised with an identified functional type. List of types has been expanded to include functions from guava, kotlin internals, apache commons and a small number of special case libraries.
Consideration was given to treating any type on the classpath annotated with
FunctionalInterfaceas a function type. This was rejected due to the performance hit for the scan of all dependencies. Although the user's own code could be scanned, this would result in a confusing difference in behaviour.