Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] DVR Delete comfirm dialog #251

Open
lesharodin opened this issue May 21, 2023 · 5 comments
Open

[Feature Request] DVR Delete comfirm dialog #251

lesharodin opened this issue May 21, 2023 · 5 comments

Comments

@lesharodin
Copy link

In playback menu it says hold right button to delete video file, but it gets deleted even on short press.

@pitts-mo
Copy link
Contributor

Confirmed:
I unfortunately discovered this today while testing #249.

Not only should it be a hold press it should present a warning dialog to confirm delete with a quick enter (center wheel) press.

@lesharodin
Copy link
Author

Fixed in new fw

@pitts-mo
Copy link
Contributor

pitts-mo commented Jun 21, 2023

@lesharodin I find this is still occurring for me on 9.1.0-rc3 and think this should be keep open until a warning dialog is added.

Can you double check a quick click of right button is not deleting the selected DVR, verify the firmware version installed on your goggle, and that you are not running an old build from SD card?

@lesharodin
Copy link
Author

lesharodin commented Jun 21, 2023

@pitts-mo
Hmm just checked again, seems like it works on main branch
On click its how on hold it deletes, but you can't delete HOT file
But Yeah we need comfirmation dialog

@lesharodin lesharodin reopened this Jun 21, 2023
@lesharodin lesharodin changed the title DVR get deleted on click, not hold. [Feature Request] DVR Delete comfirm dialog Jun 21, 2023
@wxyzsupermod
Copy link

@lesharodin I added this after after deleting my DVR on accident trying to hot it. Addressed in #443

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants