Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Confirmation Dialog On Pressing Delete in Playback Menu #443

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

wxyzsupermod
Copy link

@wxyzsupermod wxyzsupermod commented Sep 22, 2024

This PR is to add a dialog confirmation before deleting user data. I accidentally deleted a file while trying to hot it at a race and deleted my best run of the day. I don't want to have that happen to others so I have added this dialog.
image

@sanderpuh
Copy link
Contributor

sanderpuh commented Oct 9, 2024

Nice quality of life feature!

Suggestion on the displayed text from my side (remove capital D and add questionmark):
Are you sure you want to Delete the file -> Are you sure you want to delete the file?

Also, what should I click (or press) and what is the function key?
Click to continue. Press function to exit.

Perhaps something like the following example:
Press again to delete, scroll to cancel.

Or similar, the above example confirms to the user which button to press (or scroll).

@wxyzsupermod
Copy link
Author

wxyzsupermod commented Oct 26, 2024

Nice quality of life feature!

Suggestion on the displayed text from my side (remove capital D and add questionmark): Are you sure you want to Delete the file -> Are you sure you want to delete the file?
Delete was capitalized for emphasis I'm going to make it all caps for DELETE.

Also, what should I click (or press) and what is the function key? Click to continue. Press function to exit.
The function key is the term for the right button on the goggles most should know what it is

Perhaps something like the following example: Press again to delete, scroll to cancel.

Or similar, the above example confirms to the user which button to press (or scroll).

I now have click right button(function), or scroll to cancel. Only clicking center of scroll wheel will delete the file. I wanted it to be right button to cancel as the user enters deletion with that button so if they hold click it and mindlessly click the same button again it cancels only by clicking with the other hand do we delete the file.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants