-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add date-based naming scheme for DVR files and add video metadata #379
Conversation
Otherwise, when deleting a video file from the list, names can potentially get messed up when the entry's previous name was shorter than the new one. This lead to files being displayed as "hdz_xxx-24T12_48_32" for example.
I was playing with this feature on the emulator and noticed I'm unable to change the Naming Scheme option because there is no RTC battery installed on the Emulator. Do you think this option should be disabled in a similar fashion to your other PR, if no RTC battery is present then the row is not selectable and has a darker shade? Perhaps mark the PR as a draft until the other PR has been merged, that way it follows the standard you have set forth. Besides that I think this is great and much more intuitive, especially if a user enables the Date/Time in the Live View... gives them an idea of when they flew. Actually I could see us temporary blinking the Date/Time in live view when the recording is started.... that way we don't need to have it on permanently.... but that would potentially be a future feature. Final comment... though its more of a personal preference.... i think we should simplify the timestamp convention to something a little more readable perhaps... 2023-11-24T13_34_37.mp4 |
You're right. I already had that in mind but wasn't sure how to correctly go ahead and mark this PR to lack some work after #369. I'll convert this PR to draft in a minute 👍
Yeah we should keep that in mind. Perhaps you'd need the user to decide how they want the OSD to behave.
That's actually a good idea imho. That way you could navigate your files easier by just typing the digits instead of having to add the dashes, too. The only thing I'd change is separating the date from time with a dash instead of an undesrscore like so: |
I like your dash format better, all keys are in the same row on the keyboard. |
That was a pure coincidence, they aren't on my (German) keyboard 😆 |
Liking it, great! |
It's worth noting that it appears that this PR also changed hot clip naming? (At least I assume it was this PR, I see that |
That was indeed unintentional 😅 |
@Master92 If we do intend to keep it as it currently is, then we should probably remove unused code |
@evilC agreed. I'm currently working on that file for the date-folder feature and will try to keep removing that in mind 👍 |
@evilC I'd be okay with that as well 😉👍 |
This PR allows users with an active RTC to chose between the conventional naming scheme (i.e. hdz_000, hdz_001 etc.) and a date-based one (i.e. 2023-11-24T13_34_37).
When no rtc battery is present, the user can not change the naming scheme. On top of that, it automatically falls back to the conventional scheme as default.
Further, I added some metadata to the DVR files i.e. a title (currently the file name) and - for mp4 - the date it was created.
Over the course of my research and the implementation, I found out that the ts container does not support any metadata information about the media creation date, hence a note in the sources.
Closes #42
Closes #116