Adding PyGears to base #229
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing talk, since I'm not sure what it is
5 tasks
umarcor
reviewed
Feb 26, 2022
There was a problem hiding this comment.
Thanks for opening this PR!
Overall, the idea of hdl/awesome is to provide a brief description of each tool/project (2-3 paragraphs), along with references to the repos, websites, docs, etc. where users can find further details. From this point of view, the content proposed in the body of this PR is too much. Could you please reduce it? For instance, you could make "Single interface type", "Synchronization", "Data types", "Functional style", "HLS", "Verification" and "Ecosystem" a list of references to the corresponding sections in PyGears' README or docs.
|
@umarcor Thanks for the input, give me a day or two to fix this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey people, I just added PyGears to base. Also, I made a new folder in static/img/items/pygears, I wasn't sure if this is the right way to do it, please let me know.