Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added incompatibility flag to prepare for flip in future Bazel versions #291

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

abrisco
Copy link
Collaborator

@abrisco abrisco commented Mar 2, 2024

A quick query seemed to prove the repo is compliant with incompatible_disallow_empty_glob but it'd be good to add regardless to avoid future regressions.

@QuantamHD
Copy link
Collaborator

/gcbrun

@QuantamHD
Copy link
Collaborator

/gcbrun

@QuantamHD
Copy link
Collaborator

Looks like there's some RPM related error https://app.buildbuddy.io/invocation/554468ea-d9a8-11ee-8ecb-0242c0a80a02

@abrisco
Copy link
Collaborator Author

abrisco commented Mar 4, 2024

Looks like there's some RPM related error https://app.buildbuddy.io/invocation/554468ea-d9a8-11ee-8ecb-0242c0a80a02

Yeah, I was definitely wrong when I mentioned the repo looked compliant. But the way the repo is tested is also slightly flawed. It shouldn't be checking @rules_pkg//... and things like that. Instead there should be sufficient uses of each external repo within rules_hdl to cover what needs to be tested. I think this might be blocked by bazelbuild/rules_pkg#825

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants