Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sim: add xyce #263

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

sim: add xyce #263

wants to merge 5 commits into from

Conversation

proppy
Copy link
Contributor

@proppy proppy commented Dec 13, 2022

Fixes #210

@proppy
Copy link
Contributor Author

proppy commented Dec 21, 2022

Seems like this is failing on conda-build-prepare:

2022-12-21T12:52:21.9200403Z error: tag 'Public_Release-7.6.0-77-g50daf8e8e069363aea2fe91cc8012a8d3038bd87' not found.
2022-12-21T12:52:21.9211902Z Traceback (most recent call last):
2022-12-21T12:52:21.9212281Z Preparing the environment, please wait...
2022-12-21T12:52:21.9213430Z   File "/tmp/really-long-path/conda/lib/python3.7/runpy.py", line 193, in _run_module_as_main
2022-12-21T12:52:21.9213827Z     "__main__", mod_spec)
2022-12-21T12:52:21.9214247Z   File "/tmp/really-long-path/conda/lib/python3.7/runpy.py", line 85, in _run_code
2022-12-21T12:52:21.9214623Z     exec(code, run_globals)
2022-12-21T12:52:21.9215159Z   File "/tmp/really-long-path/conda/lib/python3.7/site-packages/conda_build_prepare/__main__.py", line 54, in <module>
2022-12-21T12:52:21.9215597Z     prepare_recipe(recipe_dir, git_dir, env_dir)
2022-12-21T12:52:21.9216174Z   File "/tmp/really-long-path/conda/lib/python3.7/site-packages/conda_build_prepare/conda_cmds.py", line 363, in prepare_recipe
2022-12-21T12:52:21.9216616Z     git_rewrite_tags(first_git_repo_path)
2022-12-21T12:52:21.9217179Z   File "/tmp/really-long-path/conda/lib/python3.7/site-packages/conda_build_prepare/git_helpers.py", line 247, in git_rewrite_tags
2022-12-21T12:52:21.9217550Z     git_drop_tag(git_repo, tag)
2022-12-21T12:52:21.9218117Z   File "/tmp/really-long-path/conda/lib/python3.7/site-packages/conda_build_prepare/git_helpers.py", line 194, in git_drop_tag
2022-12-21T12:52:21.9218634Z     _call_custom_git_cmd(git_repo, f'tag -d {tag}')
2022-12-21T12:52:21.9219169Z   File "/tmp/really-long-path/conda/lib/python3.7/site-packages/conda_build_prepare/git_helpers.py", line 144, in _call_custom_git_cmd
2022-12-21T12:52:21.9219602Z     stdout=subprocess.PIPE).stdout
2022-12-21T12:52:21.9220095Z   File "/tmp/really-long-path/conda/lib/python3.7/subprocess.py", line 512, in run
2022-12-21T12:52:21.9220470Z     output=stdout, stderr=stderr)
2022-12-21T12:52:21.9221087Z subprocess.CalledProcessError: Command '['git', 'tag', '-d', 'Public_Release-7.6.0-77-g50daf8e8e069363aea2fe91cc8012a8d3038bd87']' returned non-zero exit status 1.
2022-12-21T12:52:21.9399623Z 
2022-12-21T12:52:21.9399759Z Cloning git sources...
2022-12-21T12:52:21.9399949Z 
2022-12-21T12:52:21.9400132Z Modifying git tags to set proper package version...
2022-12-21T12:52:21.9400342Z 
2022-12-21T12:52:21.9400662Z Rewriting tags in "/home/runner/work/conda-eda/conda-eda/workdir/git-repos/Xyce"...

@ajelinski can you comment why tag rewriting is necessary?

@mithro
Copy link
Member

mithro commented Dec 21, 2022

@proppy - Tag rewriting is required so the git-describe used in conda returns something compatible with conda version information.

@mithro
Copy link
Member

mithro commented Dec 21, 2022

@proppy - We need the output from that git command to understand why it is failing.

@proppy
Copy link
Contributor Author

proppy commented Dec 21, 2022

@proppy - We need the output from that git command to understand why it is failing.

I think that's the first line of the log:

2022-12-21T12:52:21.9200403Z error: tag 'Public_Release-7.6.0-77-g50daf8e8e069363aea2fe91cc8012a8d3038bd87' not found.

Not sure where the Public_ comes from as Xyce doesn't use this for its tagging convention: https://github.com/Xyce/Xyce/tags

@proppy
Copy link
Contributor Author

proppy commented Dec 22, 2022

Xyce 🍙 git describe --tags --abbrev=0
warning: tag 'Release-7.6.0' is externally known as 'Public_Release-7.6.0'
Public_Release-7.6.0-77-g50daf8e8e069363aea2fe91cc8012a8d3038bd87

That explains it!

After reading some chatter about git behavior here: https://patchwork.kernel.org/project/git/patch/fcf19a46b80322c5579142efe4ec681a4dcbdd28.1581802264.git.matheus.bernardino@usp.br/

It doesn seems weird that git describe return something that git tag can't handle.

@proppy
Copy link
Contributor Author

proppy commented Dec 22, 2022

Filed hdl/conda-build-prepare#1

@proppy
Copy link
Contributor Author

proppy commented Dec 22, 2022

I believe we can fix it with hdl/conda-build-prepare#2.

@saicharan0112
Copy link

@proppy I see the same message regarding the and Public_ while installing the xyce. Though it dumps that message as a warning not as an error. I mentioned this in the xyce slack channel - https://open-source-silicon.slack.com/archives/C01TLV579C5/p1670139629104189. Not sure if this is of any help or if you want to add something to that conversation thread.

Copy link
Contributor

@ajelinski ajelinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recipe generally LGTM but apart from the conda-build-prepare issue that I'm working on I got such an error during building:

-- Installing: $PREFIX/lib/cmake/tribits/examples/TribitsExampleProject/packages/wrap_external/cmake
+ cd $WORKDIR
+ cmake -B build '-DCMAKE_FIND_ROOT_PATH=$BUILD_PREFIX;$PREFIX' -DCMAKE_FIND_ROOT_PATH_MODE_INCLUDE=ONLY -DCMAKE_FIND_ROOT_PATH_MODE_LIBRARY=ONLY -DCMAKE_FIND_ROOT_PATH_MODE_PROGRAM=ONLY -DCMAKE_INSTALL_PREFIX=$PREFIX .
CMake Warning at $PREFIX/lib/cmake/Kokkos/KokkosConfig.cmake:190 (MESSAGE):
  The installed Kokkos configuration does not support CXX extensions.
  Forcing -DCMAKE_CXX_EXTENSIONS=Off
Call Stack (most recent call first):
  $PREFIX/lib/cmake/Amesos2/Amesos2Config.cmake:170 (include)
  $PREFIX/lib/cmake/Stokhos/StokhosConfig.cmake:154 (include)
  $PREFIX/lib/cmake/TrilinosCouplings/TrilinosCouplingsConfig.cmake:153 (include)
  $PREFIX/lib/cmake/Trilinos/TrilinosConfig.cmake:130 (include)
  CMakeLists.txt:42 (find_package)


CMake Error at CMakeLists.txt:55 (message):
  ERROR: Trilinos version 13.4.1 is less than the required minimum of 13.5.
  Install a version of Trilinos of 13.5 or greater.

(replaced .../_host_env..., .../_build_env and .../work paths with $PREFIX, $BUILD_PREFIX and $WORKDIR, respectively)

Comment on lines +737 to +738
env:
PACKAGE: "sim/xyce"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
env:
PACKAGE: "sim/xyce"
env:
CONDA_BUILD_PREPARE_REV: "aj-fix-describe"
PACKAGE: "sim/xyce"

Please set this variable to use conda-build-prepare WIP branch that is able to handle "misnamed" tags for now to build Xyce until hdl/conda-build-prepare#1 gets fixed. I've just pushed a commit to conda-eda's master` to enable specifying it so please first rebase this PR on top of it.

@proppy proppy mentioned this pull request Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Xyce simulator as a package
4 participants