Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow override of constructor args and object attrs to return None #1167

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

rly
Copy link
Contributor

@rly rly commented Aug 10, 2024

Motivation

Fix #178

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

@rly rly requested a review from mavaylon1 August 10, 2024 08:03
Copy link

codecov bot commented Aug 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.90%. Comparing base (316ec4b) to head (56e13b8).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1167      +/-   ##
==========================================
+ Coverage   88.88%   88.90%   +0.02%     
==========================================
  Files          45       45              
  Lines        9835     9835              
  Branches     2795     2795              
==========================================
+ Hits         8742     8744       +2     
+ Misses        776      775       -1     
+ Partials      317      316       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Oliver Ruebel <oruebel@users.noreply.github.com>
@rly
Copy link
Contributor Author

rly commented Aug 10, 2024

This causes a few errors in PyNWB that I will investigate.

@mavaylon1
Copy link
Contributor

This causes a few errors in PyNWB that I will investigate.

Is this PR okay to review or should I wait for the PyNWB errors.

@rly
Copy link
Contributor Author

rly commented Aug 19, 2024

This causes a few errors in PyNWB that I will investigate.

Is this PR okay to review or should I wait for the PyNWB errors.

Please wait to merge. I haven't had time to look through these yet. If it does not make it in this upcoming release, that is OK.

@rly rly marked this pull request as draft August 19, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow overwrite of constructor arguments to return None
3 participants