frontend: Fix memoization for Head cell when selecting all rows #2678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksandr Dubenko <oldubenko@microsoft.com>
dosubot
bot
added
the
size:S
sniok
added
bug
|
Have you tested the changes? I switched to this feature branch and seems to me that the table selection acts functionally identical to the main branch, which is the same as in the MRT docs (correct me if I'm wrong but is there an issue to fix here?) |
|
Currently when you select one item, the top "select all" checkbox has a "-" icon as expected. |
dosubot
bot
added
the
size:S
skoeva
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2669
This bug only occurs when the table has more than one page.
Steps to reproduce