Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Add new LogViewer stories #2819

Merged

Conversation

adwait-godbole
Copy link
Contributor

@adwait-godbole adwait-godbole commented Jan 31, 2025

Related to #931

Screencast.from.2025-01-31.16-26-51.webm

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Jan 31, 2025
@adwait-godbole adwait-godbole force-pushed the feat/new-logviewer-stories branch 2 times, most recently from cf8aad4 to 61f4c7b Compare January 31, 2025 11:21
@adwait-godbole adwait-godbole changed the title frontend: add new LogViewer stories frontend: Add new LogViewer stories Jan 31, 2025
Signed-off-by: adwait-godbole <adwaitngodbole@gmail.com>
@adwait-godbole adwait-godbole force-pushed the feat/new-logviewer-stories branch from 523c552 to 761049b Compare February 3, 2025 13:37
Copy link
Contributor

@sniok sniok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!

Copy link
Collaborator

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎈

Very comprehensive. Thank you.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 7, 2025
@illume illume merged commit 479cd7a into headlamp-k8s:main Feb 7, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants