Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ARM vs x86 logic error & ChromeOS no longer has wget #51

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

thedamian
Copy link

There has always been a logic error when looking for an "ARM" processor.

If you have ARM it runs the x86 code
and if you have x86 it runs the ARM code.
BOTH fail.

ALSO since chromeOS 66 or 67 we've lost wget and we only have the "curl" command.

Both fixes are in this PR.

when you DID find an ARM64 (or didn't) it would run the opposite code.
@thedamian
Copy link
Author

confirmed on a Samsung Chromebook Pro (with m5 process, which is 64_x86. essentially the Intel m5 is a slow intel i5 64bit x86 processor)

I'm on the dev channel which has chromeos 68.* but ever since chromeos 66 or 67 we lost wget.

Copy link

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm this patch fixes the install process.

@thedamian thedamian mentioned this pull request Jul 23, 2018
@thedamian
Copy link
Author

Since this change is "Approved" what's the NEXT step to get it merged?

And It'll need the documentation changes in PR #55 to make it fully compatible with chromebook (both x86 and ARM)

Copy link
Owner

@headmelted headmelted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the lateness in coming back to this.

The intention here was to direct arm64 users down the armhf path until such time as native arm64 was implemented - at the minute I'm working on that as Electron now supports it.

I'll come back to this at that time, as more changes might be necessary once native arm64 lands in the code.

@thedamian
Copy link
Author

@headmelted My changes are because you have the logic BACKWARDS.

IF Arm
Do x86 code
else
Do Arm Code

@thedamian
Copy link
Author

I completely understand Personal issues getting in the way.
Everyone sounds so ROUGH and HEARTLESS in text (I certainly do) but that's is definitely not my intention.

@headmelted
Copy link
Owner

headmelted commented Jul 23, 2018 via email

@thedamian
Copy link
Author

@headmelted Fixed the merge conflict. It's ready for you to merge.

@thedamian
Copy link
Author

** BUMP **
@headmelted do you have any time for this PR?
I see you've updated Visual studio to the latest. That's SUPER appreciated as I pointed someone with an ARM linux laptop to your amazing repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants