-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes ARM vs x86 logic error & ChromeOS no longer has wget #51
base: master
Are you sure you want to change the base?
Conversation
when you DID find an ARM64 (or didn't) it would run the opposite code.
curl instead of wget
confirmed on a Samsung Chromebook Pro (with m5 process, which is 64_x86. essentially the Intel m5 is a slow intel i5 64bit x86 processor) I'm on the dev channel which has chromeos 68.* but ever since chromeos 66 or 67 we lost wget. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm this patch fixes the install process.
Since this change is "Approved" what's the NEXT step to get it merged? And It'll need the documentation changes in PR #55 to make it fully compatible with chromebook (both x86 and ARM) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the lateness in coming back to this.
The intention here was to direct arm64 users down the armhf path until such time as native arm64 was implemented - at the minute I'm working on that as Electron now supports it.
I'll come back to this at that time, as more changes might be necessary once native arm64 lands in the code.
@headmelted My changes are because you have the logic BACKWARDS. IF Arm |
I completely understand Personal issues getting in the way. |
You sounded absolutely fine don't worry 🙂. I've just not had any time to
come back to this, but getting more time to bring it up to date now!
…On Mon, Jul 23, 2018, 14:46 Damian Montero ***@***.***> wrote:
I completely understand Personal issues getting in the way.
Everyone sounds so ROUGH and HEARTLESS in text (I certainly do) but that's
is definitely not my intention.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#51 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AKYVoOjEoWttD4Nkc8RcvOA5y2LREaGmks5uJdPGgaJpZM4Ugpg1>
.
|
@headmelted Fixed the merge conflict. It's ready for you to merge. |
** BUMP ** |
There has always been a logic error when looking for an "ARM" processor.
If you have ARM it runs the x86 code
and if you have x86 it runs the ARM code.
BOTH fail.
ALSO since chromeOS 66 or 67 we've lost wget and we only have the "curl" command.
Both fixes are in this PR.