Dynamic dependency install, better GPG key install, and other minor stuff #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test for and only install missing dependencies
The install script generally needs root priv, so will now gracefully bug out if it don't have them.
Closes several issue around GPG key not being properly installed
pfeerick
changed the title
|
Writing this on phone at the minute but will be in front of laptop later today though and hopefully get this merged then. Thanks for taking the time to put this together! |
Quieten apt-get update and install without completely quashing output, remove duplicate architecture message
Extra characters, can add to confusion as not consistently used in file.
|
Sorry for the delay... next few days become a week! :-O Latest changes are mostly cosmetic, no errrors were introduced, or any further functional changes made. @headmelted Is there a pre or post-install script included in the deb file? I'm trying to pin down the cause of the (failing) mid-install attempt to install the GPG key, and refresh the apt-cache, as that should not be happening during the install process. When you look at the output below, the steps between Otherwise, this is working quite well now. Tested against fresh unconfigured installs of Raspbian Strech and Buster, on a Raspberry Pi 3B+. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the discussion that was happening in #92, I've put my 💰 where my 😮 is and done a PR 😉
This PR introduces:
If adopted, this PR Resolves #92; Resolves #76; Resolves #71; Resolves #63.
Note: These changes are completely untested at this point in time (but have passed shellcheck testing), so aren't in a fit state to merge right of this second. I don't expect any breakage, but expectation and reality often don't see eye to eye ;) Testing will happen within the next few days.
I would like to make some other minor changes, but they are style changes so need discussion first. Shell scripts don't need trailing
;at the end of commands, so I would like to remove them where not required which. Also, I want to change to tab indentation, rather than whitespace indentation.Key reasoning for both changes is to the make the script fractionally smaller, improve consistency, and reduce chance of confusion later down the path.