Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Piece-Square Tables position evaluation #13

Merged
merged 3 commits into from
Jun 1, 2021
Merged

Fixed Piece-Square Tables position evaluation #13

merged 3 commits into from
Jun 1, 2021

Conversation

Varsius
Copy link
Contributor

@Varsius Varsius commented May 31, 2021

Reversed the rows of the Piece-Square Tables as explained here.
Also added a small testcast to verify the functionality.

@healeycodes
Copy link
Owner

Hi @Varsius!

This looks great.

Two things:

  • Can you fix the two failing tests? I think it's because the move values changed and the tests need to be updated.
  • Do you think another test is necessary to cover black's POV? i.e. if black responds to e2e4 with e7e5 then black's positional value should improve.

@Varsius
Copy link
Contributor Author

Varsius commented Jun 1, 2021

Oh sorry, that is my bad.. I will be working on a fix soon. And adding another test is no problem.

@Varsius
Copy link
Contributor Author

Varsius commented Jun 1, 2021

Tests should be fixed now.

@healeycodes
Copy link
Owner

Thanks for the PR! This closes #12

@healeycodes healeycodes merged commit 3997c27 into healeycodes:main Jun 1, 2021
@healeycodes healeycodes mentioned this pull request Jun 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Varsius @healeycodes