Fix SystemStackError with ActiveRecord #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ActiveRecord::Schema.define do | ||
| self.verbose = false | ||
|
|
||
| create_table :activerecord_users, :force => true do |t| |
garethrees
force-pushed
the
stack-too-deep
branch
2 times, most recently
from
a2d02ff to
79a7fed
Compare
|
Cleared up some Hound warnings – remaining ones are just following existing conventions. |
| end | ||
| rescue => e | ||
| warn "#{$0}: #{e}" | ||
|
|
garethrees
force-pushed
the
stack-too-deep
branch
from
9776b3a to
a829c9d
Compare
If you use the default `otp_counter` column name, InstanceMethodsOnActivation#otp_counter calls `otp_counter` resulting in a stack overflow.
garethrees
force-pushed
the
stack-too-deep
branch
from
a829c9d to
4592b82
Compare
garethrees
referenced
this pull request
in mysociety/alaveteli
Oct 9, 2015
- Adds forked gem for temporary fix; see commit ref for details - Regenerates the secret and counter when enabled
|
Anything I can do to help get this merged? Cheers. |
|
@garethrees sorry for the delay, I'm going to take a look today |
|
@robertomiranda thanks, much appreciated! Feel free to get in touch if there's anything you need to clarify :) 🍻 |
mysociety-pusher
pushed a commit
to mysociety/alaveteli
that referenced
this pull request
May 17, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26
If you use the default
otp_countercolumn name,InstanceMethodsOnActivation#otp_countercallsotp_counterresulting in a stack overflow.