Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(darktheme): switch to mode-watcher #223

Merged
merged 4 commits into from
Apr 13, 2024

Conversation

aleksasiriski
Copy link
Member

No description provided.

Copy link

vercel bot commented Apr 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2024 8:36pm

Copy link
Member

@matijakljajic matijakljajic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would leave transitions off for the time being. Multiple elements on Hearchco currently have different transition timings. Consequently, it'll look really messy on theme change.

matijakljajic
matijakljajic previously approved these changes Apr 13, 2024
@matijakljajic
Copy link
Member

LGTM, we'll update the CSS theming we talked about when we both find the time as it's not that important.

@aleksasiriski aleksasiriski merged commit 2d3c038 into main Apr 13, 2024
3 of 5 checks passed
@aleksasiriski aleksasiriski deleted the as/fix/dark-theme-toggle-lib branch April 13, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants