Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Rewrite in Svelte 5 #251

Merged
merged 60 commits into from
May 19, 2024
Merged

feat!: Rewrite in Svelte 5 #251

merged 60 commits into from
May 19, 2024

Conversation

aleksasiriski
Copy link
Member

@aleksasiriski aleksasiriski commented May 8, 2024 •
edited
Loading

Closes #181
Closes #149
Closes #229

  • Rewrite in Svelte 5 (using runes for reactivity) and JSDoc (instead of TS)
  • Rewrite with latest TailwindCSS
  • Refactor CSS removing useless classes
  • Refactor HTML removing useless tags
  • Added <meta name="color-scheme" content="dark light" /> to <head>
  • Added PUBLIC_URI env var (for frontend)
  • ^ Added opensearch.xml endpoint
  • Switch image preview to use thumbnails - [BUG] Preview not working *sometimes* #181
  • Switch category to parameter (query takes precedence)
  • Sort query params before every fetch (highers the chance of a cache hit)
  • Added an indicator when API returns 0 results
  • Added timing of API fetch - [FEAT] Add a "results retrieved in x seconds" thingy #149
  • Made everything work w/o Javascript (removed response streaming, paginator for general and images, infinite loading when JS is available with preloading)
  • Shorten description to 500 chars and make it show full on button ... instead of on hover (w/ JS only, could have fallback to full desc and line-clamp-6 and onhover line-clamp-none) - [BUG] Long descriptions #229
  • Prevent empty query from fetching API (w/ JS only, could have fallback to input "required")
  • Focus searchbox on reset (w/ JS only, could have fallback to input type "search")
  • Added / animation to indicate loading
  • Added /search animation for general results to indicate loading
  • Added /search animation for images results to indicate loading
  • Switched to custom dark theme toggle instead of mode watcher (should be much improved upon with themes rewrite)

Investigate:

  • Wrong origin set, which breaks universal load func when running on server (it's set to the S3 bucket url instead of the Cloudfront host which is hearch.co)
  • Timing being overwritten during hydration (w/ universal loading only) - Because of current CORS issues a server load function is being used which doesn't have this bug, but it can still be seen here

@aleksasiriski aleksasiriski marked this pull request as draft May 8, 2024 17:33
@aleksasiriski
chore: readme and sec
696faff
@aleksasiriski
feat(search): timing
d066a97
@aleksasiriski
feat: error pages
18a5e15
@aleksasiriski
fix(searchbox): reset form alignment on firefox
e295265
@aleksasiriski
fix(error,zero): responsiveness
fe30f7a
@aleksasiriski
fix(searchbox): maintain selected category
f69d6d0
@aleksasiriski
fix(searchbox): undefined category
9a1d6b8
@aleksasiriski
fix(preview): close on espace key only
5b57e2f
@aleksasiriski
fix(paginator): remove TODO since it needs JS
1c1276c
@aleksasiriski
fix(infiniteloading): preload results
07df750
@aleksasiriski
fix(infiniteloading): remove unused import
80a7808
@aleksasiriski
chore: force runes
996a751
@aleksasiriski
fix(css): switch gray to neutral
4b27141
@aleksasiriski
fix(api): always sort params and remove unused before fetch
eb9343c
@aleksasiriski
chore: Makefile, testing CI, prettier formatting
1b4b219
@aleksasiriski
chore: linting
956b9d0
@aleksasiriski
chore: updated deps
3ff154d
@aleksasiriski
fix(general): long description button
bb4b713
@aleksasiriski
feat(homepage): loading on form submit
fbeef82
@aleksasiriski
fix(searchbox): prevent submitting when query is empty
2078341
@aleksasiriski
fix: searchbox affecting infinite loading
2de128f
@aleksasiriski
fix: mandatory query param and lint error
ea409f5
@aleksasiriski
revert: mandatory query param
14ed4ea
@aleksasiriski
ci: disable Docker for PRs
1401b34
@aleksasiriski
feat(searchssr): added route for SSR testing (should be removed)
3682f5e
@aleksasiriski
fix(opensearch.xml): formatting
fcc5fb9
@aleksasiriski
fix(search): make search work and searchbad not
7d3e124
@aleksasiriski
fix(search): propagate server load to universal load
0ca6bb1
@aleksasiriski
fix(opensearch.xml): favicon
2656b79
@aleksasiriski
chore: disable playwright testing
d2b28cf
@aleksasiriski
fix(searchbox): focus on reset
be92b96
@aleksasiriski
fix(searchbox): responsiveness
894001a
@aleksasiriski
feat: added simple JS theme toggle
d304944
@aleksasiriski
fix(themetoggle): lint
8ee3508
@aleksasiriski
fix(categories)!: sync to latest backend changes
97b9d50
@aleksasiriski
fix(categories): working switch case
208dba1
@aleksasiriski
fix: better category extraction and API error message
f18aa58
@aleksasiriski
fix(homepage): css padding and footer
31e35ae
@aleksasiriski
fix(searchbox): better pading and categories
07a40fd
@aleksasiriski
fix(results): css divide and better padding
8e4398d
@aleksasiriski
fix: searchbox logo and more screens
4d98510
@aleksasiriski
fix(general): lint
61e929b
@aleksasiriski
fix(general): break words instead of overflow hidden
109afef
@aleksasiriski
fix(preview): dark background and padding
dc9a3df
@aleksasiriski
fix(preview): better check when to show button for longer desc
00883e3
@aleksasiriski
fix(stats): add a separate timing for measuring SSR time and latency …
afe67b8 
…to that alongside API fetch
@aleksasiriski
fix(searchbad): stats
64b98cd
@aleksasiriski
Revert "fix(searchbad): stats"
d32382c 
This reverts commit 64b98cd.
@aleksasiriski
Revert "fix(stats): add a separate timing for measuring SSR time and …
fa84f4b 
…latency to that alongside API fetch"

This reverts commit afe67b8.
@aleksasiriski
fix(searchbox): query not returning to previous on page back
0f445eb
@aleksasiriski
fix(infiniteloading): less work for preload
e766ade
@aleksasiriski aleksasiriski marked this pull request as ready for review May 19, 2024 19:43
@aleksasiriski aleksasiriski merged commit 216cd6d into main May 19, 2024
3 checks passed
@aleksasiriski aleksasiriski deleted the as/feat/svelte-5-rewrite branch May 19, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@aleksasiriski