Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we cover this change with tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked up all the current methods in Devise that use 'is_navigational_format?' checks and I couldn't seem to find anything in those tests that specifically incorporate a test for that navigational check. In my previous pull requests for Devise, I wrote my tests based off similar structured methods and their corresponding tests. However, since I cannot find how the other methods using 'is_navigational_format?' are testing it, I am not sure how to
incorporate additional tests for the method I added it to. Based on the issue conversation, i was under the impression that the method I changed used to have a 'is_navigational_format?' check and that it somehow got deleted by accident from a git reset. So I simply added it back to the method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, we don't have tests for any of these so I think it's ok for now.