Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Devise modules to register multiple routes #5630

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions lib/devise.rb
Original file line number Diff line number Diff line change
Expand Up @@ -408,22 +408,30 @@ def self.add_module(module_name, options = {})
NO_INPUT << strategy if options[:no_input]

if route = options[:route]
routes = {}

case route
when TrueClass
key, value = module_name, []
routes[module_name] = []
when Symbol
key, value = route, []
routes[route] = []
when Hash
key, value = route.keys.first, route.values.flatten
routes = route
else
raise ArgumentError, ":route should be true, a Symbol or a Hash"
end

URL_HELPERS[key] ||= []
URL_HELPERS[key].concat(value)
URL_HELPERS[key].uniq!
routes.each do |key, value|
URL_HELPERS[key] ||= []
URL_HELPERS[key].concat(value)
URL_HELPERS[key].uniq!

ROUTES[module_name] = key
end

ROUTES[module_name] = key
if routes.size > 1
ROUTES[module_name] = routes.keys
end
end

if options[:model]
Expand Down
2 changes: 1 addition & 1 deletion lib/devise/mapping.rb
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def no_input_strategies
end

def routes
@routes ||= ROUTES.values_at(*self.modules).compact.uniq
@routes ||= ROUTES.values_at(*self.modules).compact.flatten.uniq
end

def authenticatable?
Expand Down
15 changes: 15 additions & 0 deletions test/devise_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,21 @@ class DeviseTest < ActiveSupport::TestCase
assert_equal :fruits, Devise::CONTROLLERS[:kivi]
Devise::ALL.delete(:kivi)
Devise::CONTROLLERS.delete(:kivi)

Devise.add_module(:apple, route: true)
assert_equal :apple, Devise::ROUTES[:apple]
Devise::ALL.delete(:apple)
Devise::ROUTES.delete(:apple)

Devise.add_module(:pineapple, route: { session: [nil, :new] })
assert_equal :session, Devise::ROUTES[:pineapple]
Devise::ALL.delete(:pineapple)
Devise::ROUTES.delete(:pineapple)

Devise.add_module(:mango, route: { checkout: [nil, :show], session: [nil, :new] })
assert_equal [:checkout, :session], Devise::ROUTES[:mango]
Devise::ALL.delete(:mango)
Devise::ROUTES.delete(:mango)
end

test 'should complain when comparing empty or different sized passes' do
Expand Down