Add uppercase option #7
Conversation
- Also get debugging/sourcemaps working with gulp build.
test/commands.test.ts
Outdated
| test('quick pick 3 is C structure', () => { | ||
| var g = Guid.parse('12341234-1234-1234-1234-123412341234'); | ||
| var items = GuidCommands.getQuickPickItems(g); | ||
| test('quick pick iterms are correct with only uppercase enabled', () => { |
There was a problem hiding this comment.
Fixed (in all spots).
test/commands.test.ts
Outdated
| }); | ||
|
|
||
| test('quick pick 2 is registry string', () => { |
There was a problem hiding this comment.
The original tests should be retained as regression tests. The overall change looks good, but if people have muscle memory for the current way, that should be retained. If they change the options you've added, I think it's fine to change those. But the defaults should still work as they did before and retaining the old tests as regression tests (pass whatever parameters to getQuickPickItems you need to, or use default parameter values) will help ensure that.
There was a problem hiding this comment.
I'm not sure how to do a full test on this. I set the defaults here to match the old behaviour, but I don't know how to create an integration test to show that the defaults have the correct behaviour.
|
@101100 I'd love to merge this with the couple of requested changes done. Overall it looks good. Changes are just about retaining existing behavior by default. Setting new options can change that since they themselves new. |
|
@heaths Do you know of any examples that I could base tests off of for preference defaults? Otherwise, I've fixed the typo. |
|
I'd just leave the existing tests as-is when the options you added are |
|
I've re-added the previous tests. The options passed in are |
This adds options to the GUID inserter:
insertGuid.showLowercaseinsertGuid.showUppercaseinsertGuid.showCodeSnippetsBy default, they are set with lowercase and code snippets on to match the old behaviour. If they are all set to false, then just the lowercase options are shown.
Closes #6.