Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command to insert empty guid(s) #77

Closed
wants to merge 1 commit into from

Conversation

crdonnelly
Copy link
Contributor

No description provided.

Comment on lines +67 to +71
{
"command": "guid.insertEmpty",
"key": "ctrl+shift+]",
"mac": "cmd+shift+]",
"when": "editorTextFocus"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this would get enough use to warrant a default keyboard binding. There's been enough feedback about the existing binding that I defined before VSCode later shipped it in-box that I'd rather not add bindings unless critical.

Please do consider adding the binding in your user settings, though. I can appreciate to some it may be very useful.

@heaths
Copy link
Owner

heaths commented Dec 24, 2023

Thanks for the change! Unfortunately, I'm unable to push changes myself because the default branch is protected. As a tip, it's generally better - even in a fork - to create a topic branch first. This can also help keep your main branch fast-forwardable from the upstream - my - main branch, which makes it easier for subsequent changes.

I'll keep your commits and push them to a new branch on my remote, then close this one. I just removed the key binding; otherwise, everything looks good!

@heaths
Copy link
Owner

heaths commented Dec 24, 2023

Replaced by #78

@heaths heaths closed this Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants