Skip to content

Commit

Permalink
Merge #15: Add filename to corruption errors
Browse files Browse the repository at this point in the history
135ed0f Add filename to corruption errors (Wladimir J. van der Laan)

Pull request description:

  When a corruption happens, report the filename of the file where corruptions happens.
  This will aid in diagnosing database corruption issues.

  Adds a GetName() to all the environment file classes to make it possible to report a filename downstream.

Tree-SHA512: 4b76803977ec6c2a4e113f2741619c586f5adbb2739a172e3dae3c21b79edf5a689d243850c56903e14c39b01224f8656310c2a39b3fb89ea107d7243b4794e1
  • Loading branch information
laanwj committed Nov 30, 2017
2 parents c521b3a + 135ed0f commit 64052c7
Show file tree
Hide file tree
Showing 9 changed files with 32 additions and 8 deletions.
2 changes: 1 addition & 1 deletion db/db_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ Status DBImpl::RecoverLogFile(uint64_t log_number, bool last_log,
status.ok()) {
if (record.size() < 12) {
reporter.Corruption(
record.size(), Status::Corruption("log record too small"));
record.size(), Status::Corruption("log record too small", fname));
continue;
}
WriteBatchInternal::SetContents(&batch, record);
Expand Down
1 change: 1 addition & 0 deletions db/leveldbutil.cc
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ class StdoutPrinter : public WritableFile {
virtual Status Close() { return Status::OK(); }
virtual Status Flush() { return Status::OK(); }
virtual Status Sync() { return Status::OK(); }
virtual std::string GetName() const { return "[stdout]"; }
};

bool HandleDumpCommand(Env* env, char** files, int num) {
Expand Down
2 changes: 1 addition & 1 deletion db/log_reader.cc
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ uint64_t Reader::LastRecordOffset() {
}

void Reader::ReportCorruption(uint64_t bytes, const char* reason) {
ReportDrop(bytes, Status::Corruption(reason));
ReportDrop(bytes, Status::Corruption(reason, file_->GetName()));
}

void Reader::ReportDrop(uint64_t bytes, const Status& reason) {
Expand Down
2 changes: 1 addition & 1 deletion db/repair.cc
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ class Repairer {
while (reader.ReadRecord(&record, &scratch)) {
if (record.size() < 12) {
reporter.Corruption(
record.size(), Status::Corruption("log record too small"));
record.size(), Status::Corruption("log record too small", logname));
continue;
}
WriteBatchInternal::SetContents(&batch, record);
Expand Down
3 changes: 3 additions & 0 deletions helpers/memenv/memenv.cc
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,7 @@ class SequentialFileImpl : public SequentialFile {
return Status::OK();
}

virtual std::string GetName() const { return "[memenv]"; }
private:
FileState* file_;
uint64_t pos_;
Expand All @@ -196,6 +197,7 @@ class RandomAccessFileImpl : public RandomAccessFile {
return file_->Read(offset, n, result, scratch);
}

virtual std::string GetName() const { return "[memenv]"; }
private:
FileState* file_;
};
Expand All @@ -218,6 +220,7 @@ class WritableFileImpl : public WritableFile {
virtual Status Flush() { return Status::OK(); }
virtual Status Sync() { return Status::OK(); }

virtual std::string GetName() const { return "[memenv]"; }
private:
FileState* file_;
};
Expand Down
9 changes: 9 additions & 0 deletions include/leveldb/env.h
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,9 @@ class SequentialFile {
// REQUIRES: External synchronization
virtual Status Skip(uint64_t n) = 0;

// Get a name for the file, only for error reporting
virtual std::string GetName() const = 0;

private:
// No copying allowed
SequentialFile(const SequentialFile&);
Expand All @@ -215,6 +218,9 @@ class RandomAccessFile {
virtual Status Read(uint64_t offset, size_t n, Slice* result,
char* scratch) const = 0;

// Get a name for the file, only for error reporting
virtual std::string GetName() const = 0;

private:
// No copying allowed
RandomAccessFile(const RandomAccessFile&);
Expand All @@ -234,6 +240,9 @@ class WritableFile {
virtual Status Flush() = 0;
virtual Status Sync() = 0;

// Get a name for the file, only for error reporting
virtual std::string GetName() const = 0;

private:
// No copying allowed
WritableFile(const WritableFile&);
Expand Down
10 changes: 5 additions & 5 deletions table/format.cc
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ Status ReadBlock(RandomAccessFile* file,
}
if (contents.size() != n + kBlockTrailerSize) {
delete[] buf;
return Status::Corruption("truncated block read");
return Status::Corruption("truncated block read", file->GetName());
}

// Check the crc of the type and the block contents
Expand All @@ -92,7 +92,7 @@ Status ReadBlock(RandomAccessFile* file,
const uint32_t actual = crc32c::Value(data, n + 1);
if (actual != crc) {
delete[] buf;
s = Status::Corruption("block checksum mismatch");
s = Status::Corruption("block checksum mismatch", file->GetName());
return s;
}
}
Expand All @@ -119,13 +119,13 @@ Status ReadBlock(RandomAccessFile* file,
size_t ulength = 0;
if (!port::Snappy_GetUncompressedLength(data, n, &ulength)) {
delete[] buf;
return Status::Corruption("corrupted compressed block contents");
return Status::Corruption("corrupted compressed block contents", file->GetName());
}
char* ubuf = new char[ulength];
if (!port::Snappy_Uncompress(data, n, ubuf)) {
delete[] buf;
delete[] ubuf;
return Status::Corruption("corrupted compressed block contents");
return Status::Corruption("corrupted compressed block contents", file->GetName());
}
delete[] buf;
result->data = Slice(ubuf, ulength);
Expand All @@ -135,7 +135,7 @@ Status ReadBlock(RandomAccessFile* file,
}
default:
delete[] buf;
return Status::Corruption("bad block type");
return Status::Corruption("bad block type", file->GetName());
}

return Status::OK();
Expand Down
8 changes: 8 additions & 0 deletions util/env_posix.cc
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,8 @@ class PosixSequentialFile: public SequentialFile {
}
return Status::OK();
}

virtual std::string GetName() const { return filename_; }
};

// pread() based random-access
Expand Down Expand Up @@ -172,6 +174,8 @@ class PosixRandomAccessFile: public RandomAccessFile {
}
return s;
}

virtual std::string GetName() const { return filename_; }
};

// mmap() based random-access
Expand Down Expand Up @@ -206,6 +210,8 @@ class PosixMmapReadableFile: public RandomAccessFile {
}
return s;
}

virtual std::string GetName() const { return filename_; }
};

class PosixWritableFile : public WritableFile {
Expand Down Expand Up @@ -287,6 +293,8 @@ class PosixWritableFile : public WritableFile {
}
return s;
}

virtual std::string GetName() const { return filename_; }
};

static int LockOrUnlock(int fd, bool lock) {
Expand Down
3 changes: 3 additions & 0 deletions util/env_win.cc
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ class Win32SequentialFile : public SequentialFile
virtual Status Read(size_t n, Slice* result, char* scratch);
virtual Status Skip(uint64_t n);
BOOL isEnable();
virtual std::string GetName() const { return _filename; }
private:
BOOL _Init();
void _CleanUp();
Expand All @@ -94,6 +95,7 @@ class Win32RandomAccessFile : public RandomAccessFile
virtual ~Win32RandomAccessFile();
virtual Status Read(uint64_t offset, size_t n, Slice* result,char* scratch) const;
BOOL isEnable();
virtual std::string GetName() const { return _filename; }
private:
BOOL _Init(LPCWSTR path);
void _CleanUp();
Expand All @@ -114,6 +116,7 @@ class Win32WritableFile : public WritableFile
virtual Status Flush();
virtual Status Sync();
BOOL isEnable();
virtual std::string GetName() const { return filename_; }
private:
std::string filename_;
::HANDLE _hFile;
Expand Down

0 comments on commit 64052c7

Please sign in to comment.