Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few likely typos in src/test/README.md and doc/build-windows-msvc.md #338

Closed
wants to merge 2 commits into from

Conversation

l0rinc
Copy link

@l0rinc l0rinc commented Aug 18, 2024

Split out of bitcoin#30454

Found them during review - and ran a quick spellcheck for the rest to cover any remaining ones

@l0rinc l0rinc changed the title Fix likely typo Fix likely typo in src/test/README.md Aug 18, 2024
@l0rinc l0rinc changed the title Fix likely typo in src/test/README.md Fix a few likely typos in src/test/README.md Aug 18, 2024
@l0rinc l0rinc changed the title Fix a few likely typos in src/test/README.md Fix a few likely typos in src/test/README.md and doc/build-windows-msvc.md Aug 18, 2024
@l0rinc l0rinc marked this pull request as ready for review August 18, 2024 19:34
@hebasto hebasto added the documentation Docs and manuals label Aug 19, 2024
@hebasto
Copy link
Owner

hebasto commented Aug 22, 2024

We'll proceed with these changes once bitcoin#30454 is landed.

Copy link

@pablomartin4btc pablomartin4btc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 213c236

@hebasto
Copy link
Owner

hebasto commented Aug 28, 2024

Since bitcoin#30454 has been merged, further development in this repository no longer makes sense. Please consider moving this PR to the main repository.

@l0rinc
Copy link
Author

l0rinc commented Aug 28, 2024

Moved to bitcoin#30734

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Docs and manuals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants