Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setCity() doesn't work #50

Closed
icarpis opened this issue Aug 28, 2018 · 4 comments
Closed

setCity() doesn't work #50

icarpis opened this issue Aug 28, 2018 · 4 comments
Assignees

Comments

@icarpis
Copy link
Contributor

icarpis commented Aug 28, 2018

I'm trying to get the Jerusalem candle lighting time for the coming Shabat by the following code snippet:

var hebDate = new Hebcal.HDate();
hebDate.setCity('Jerusalem');
var d = hebDate.after(5).candleLighting();

For some reason I'm getting the same time no matter if I call to setCity or not.

@mjradwin
Copy link
Member

mjradwin commented Aug 30, 2018 via email

@icarpis
Copy link
Contributor Author

icarpis commented Aug 31, 2018

Thank you @mjradwin, but I still get unreasonable times.

@mjradwin
Copy link
Member

@Scimonster can you take a look?

@Scimonster
Copy link
Contributor

It seems that the call to after() made it lose the location data. Fixed now.

(You can set the location directly on an HDate BTW.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants