[rest:disable] Fix rest disable functionality #2916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edutrul
commented
Nov 11, 2016
| ); | ||
| return true; | ||
| } | ||
| $message = sprintf($this->trans('commands.rest.disable.messages.already-disabled'), $resource_id); |
There was a problem hiding this comment.
This is a new string to translate, I am adding this because if you try to disable a rest which is already disabled then a message like
Rest ID "%s" was already disabled
I think makes sense,
else
since it is a new string to translate(and takes effort to do it in != languages) then I think I can remove that line and move lines 106-111 into 114 (which is out of "if" conditional) so that it displays always success message without taking care if it is already disabled
What do you think @enzolutions ?
|
Thanks @edutrul |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to issue #2911