[database:restore] #2174 Recreate database before importing the dump #3856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should also help #3097 |
marcelovani
commented
Apr 5, 2018
| @@ -36,8 +36,3 @@ services: | |||
| arguments: ['@database', '@date.formatter', '@entity_type.manager', '@string_translation'] | |||
| tags: | |||
| - { name: drupal.command } | |||
There was a problem hiding this comment.
Moving the code to uninstall.services.yml to make it available before we have a site running
marcelovani
commented
Apr 5, 2018
| if (strpos($file, '.sql.gz') !== false) { | ||
| $catCommand = "gunzip -c %s | "; | ||
| } else { | ||
| $catCommand = "cat %s | "; | ||
| } | ||
|
|
||
| $commands = array(); | ||
| if ($databaseConnection['driver'] == 'mysql') { |
There was a problem hiding this comment.
Drop (if exists) and Create database. This is necessary when installing the site from a dump.
|
Thanks @marcelovani for your contribution, due to some conflicts @harold20 took it and reship in other PR #4037 |
enzolutions
pushed a commit
that referenced
this pull request
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue #2174
I don't think we need a --replace option. The DROP/CREATE needs to happen every time.