Skip to content

Commit

Permalink
Merge pull request #603 from VisLab/develop
Browse files Browse the repository at this point in the history
Corrected the counts in columns value summary
  • Loading branch information
VisLab authored Feb 10, 2023
2 parents 204f29a + 3ccadd8 commit d5f43b3
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ def _get_dataset_string(result, indent=BaseContext.DISPLAY_INDENT):

@staticmethod
def _get_individual_string(name, result, indent=BaseContext.DISPLAY_INDENT):
sum_list = [f"{indent}{name}:"]
sum_list = [f"{name}: {result.get('Total events', 0)} events"]
cat_cols = result.get("Categorical columns", {})
if cat_cols:
sum_list.append(ColumnValueSummaryContext._get_categorical_string(cat_cols, offset=indent, indent=indent))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,9 @@ def test_get_summary(self):
cont = dispatch.context_dict
context1 = cont.get("test summary", None)
self.assertIsInstance(context1, ColumnValueSummaryContext, "get_summary testing ColumnValueSummary")
summary1 = context1.get_summary()
self.assertIsInstance(summary1, dict, "get_summary returns a dictionary")
self.assertIsInstance(summary1["Dataset"], dict)
# summary1 = context1.get_summary()
# self.assertIsInstance(summary1, dict, "get_summary returns a dictionary")
# self.assertIsInstance(summary1["Dataset"], dict)
summary1a = context1.get_summary()
self.assertIsInstance(summary1a, dict)
self.assertIsInstance(summary1a["Dataset"], dict)
Expand Down

0 comments on commit d5f43b3

Please sign in to comment.