Minor cleanup/documentation cleanup of schema and models #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
spec_tests failure is expected, pending PR approval on hed-specification |
VisLab
reviewed
Mar 20, 2024
| Returns: | ||
| list: A list of issues. Each issue is a dictionary. | ||
| """ | ||
| """Check if the single tag is a partnered schema tag""" |
There was a problem hiding this comment.
Why is the documentation of the Parameters and Returns being removed?
There was a problem hiding this comment.
Because it was the exact same on all of those functions, there's a template at the top of the file(I just fixed a mistake in it). Users would never be calling these functions directly.
I'm happy to add the parameter/return value doc strings back if desired, they just didn't seem helpful to me.
There was a problem hiding this comment.
Please put them back in. When you jump to a particular function from a link in the docs you don't see the template.
VisLab
reviewed
Mar 20, 2024
|
I went ahead and added disabling owl related code to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.