Skip to content
This repository has been archived by the owner on Nov 23, 2022. It is now read-only.

Update typescript-eslint monorepo to v4 (major)- autoclosed #547

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 5, 2020

This PR contains the following updates:

Package Type Update Change
@typescript-eslint/eslint-plugin dependencies major 3.10.1 -> 4.5.0
@typescript-eslint/parser dependencies major 3.10.1 -> 4.5.0

Release Notes

typescript-eslint/typescript-eslint

v4.5.0

Compare Source

Bug Fixes
  • eslint-plugin: [array-type] fix issues with readonly option (#​2667) (63d1d81)
  • eslint-plugin: [lines-between-class-members] fix typo in schema (#​2681) (a2a2514)
  • eslint-plugin: [naming-convention] check bodyless function parameters (#​2675) (c505863)
  • eslint-plugin: [no-invalid-this] allow "this" in class property definitions (#​2685) (dccb6ee)
  • eslint-plugin: [no-misused-promises] False negative in LogicalExpression (#​2682) (30a6951), closes #​2544
  • eslint-plugin: [no-unnecessary-type-assertion] correct fixer for vue files (#​2680) (55111af)
  • eslint-plugin: [return-await] do not auto-fix when type is any/unknown (#​2671) (d690c8d)
  • parser: minor fix regexp, map-filter to reduce (#​2684) (f1329f6)
Features
  • eslint-plugin: [dot-notation] add allowProtectedClassPropertyAccess option (#​2622) (bbc9e35)
  • eslint-plugin: [prefer-readonly-parameter-types] add ignoreInferredTypes option (#​2668) (91010e8)
  • eslint-plugin: [restrict-plus-operands] add intersection type determination logic (#​2628) (da71362)
  • typescript-estree: add flag EXPERIMENTAL_useSourceOfProjectReferenceRedirect (#​2669) (90a5878)

4.4.1 (2020-10-12)

Bug Fixes
  • eslint-plugin: [ban-ts-comment] support block comments (#​2644) (9c3c686)
  • eslint-plugin: [ban-types] allow banning types with specific parameters (#​2662) (77732a2)
  • eslint-plugin: [consistent-type-assertions] check type assertion in jsx props (#​2653) (393e925)
  • eslint-plugin: [no-duplicate-imports] distinguish member, default (#​2637) (c71f423)
  • eslint-plugin: [no-throw-literal] false positive with logical expressions (#​2645) (57aa6c7)
  • eslint-plugin: [no-unused-vars] fix false positives for duplicated names in namespaces (#​2659) (0d696c7)
  • eslint-plugin: [no-use-before-define] correctly handle typeof type references (#​2623) (8e44c78)
  • scope-manager: don't create a variable for global augmentation (#​2639) (6bc9325)

v4.4.1

Compare Source

Bug Fixes
  • eslint-plugin: [ban-ts-comment] support block comments (#​2644) (9c3c686)
  • eslint-plugin: [ban-types] allow banning types with specific parameters (#​2662) (77732a2)
  • eslint-plugin: [consistent-type-assertions] check type assertion in jsx props (#​2653) (393e925)
  • eslint-plugin: [no-duplicate-imports] distinguish member, default (#​2637) (c71f423)
  • eslint-plugin: [no-throw-literal] false positive with logical expressions (#​2645) (57aa6c7)
  • eslint-plugin: [no-unused-vars] fix false positives for duplicated names in namespaces (#​2659) (0d696c7)
  • eslint-plugin: [no-use-before-define] correctly handle typeof type references (#​2623) (8e44c78)
  • scope-manager: don't create a variable for global augmentation (#​2639) (6bc9325)

v4.4.0

Compare Source

Features
  • eslint-plugin: add consistent-indexed-object-style rule (#​2401) (d7dc108)
  • eslint-plugin: add extension rule no-duplicate-imports (#​2609) (498f397)

v4.3.0

Compare Source

Bug Fixes
  • eslint-plugin: added safe getTypeOfPropertyOfType wrapper (#​2567) (7cba2de)
  • experimental-utils: treat RuleTester arrays as readonly (#​2601) (8025777)
Features
  • eslint-plugin: [no-invalid-void-type] add option to allow this: void (#​2481) (ddf5660)

v4.2.0

Compare Source

Bug Fixes
  • eslint-plugin: [naming-convention] ignore properties inside object patterns (#​2566) (53a3cbc)
  • eslint-plugin: [prefer-ts-expect-error] support block comments (#​2541) (c6f72fb)
  • scope-manager: correct analysis of inferred types in conditional types (#​2537) (4f660fd)
Features

4.1.1 (2020-09-14)

Bug Fixes
  • eslint-plugin: [naming-convention] allow an array of selectors with types and modifiers (#​2415) (7ca54c3)
  • eslint-plugin: [no-implied-eval] handle the Function type (#​2435) (e1401dc)
  • eslint-plugin: [no-unused-vars] better handling for declared modules (#​2553) (02d72d4), closes #​2523
  • eslint-plugin: [no-use-before-define] false positive for function type arguments (#​2554) (189162d), closes #​2527
  • eslint-plugin: [prefer-function-type] handle this return (#​2437) (7c6fcee)
  • eslint-plugin: [return-await] don't error for in-try-catch if the return is in a catch without a finally (#​2356) (efdd521)
  • types: artificial fix needed to trigger release (b577daf)
  • types: artificial fix needed to trigger release (fc62ba8)

v4.1.1

Compare Source

Bug Fixes
  • eslint-plugin: [naming-convention] allow an array of selectors with types and modifiers (#​2415) (7ca54c3)
  • eslint-plugin: [no-implied-eval] handle the Function type (#​2435) (e1401dc)
  • eslint-plugin: [no-unused-vars] better handling for declared modules (#​2553) (02d72d4), closes #​2523
  • eslint-plugin: [no-use-before-define] false positive for function type arguments (#​2554) (189162d), closes #​2527
  • eslint-plugin: [prefer-function-type] handle this return (#​2437) (7c6fcee)
  • eslint-plugin: [return-await] don't error for in-try-catch if the return is in a catch without a finally (#​2356) (efdd521)
  • types: artificial fix needed to trigger release (b577daf)
  • types: artificial fix needed to trigger release (fc62ba8)

v4.1.0

Compare Source

Bug Fixes
  • eslint-plugin: [explicit-module-boundary-types] cyclical reference infinite recursion crash (#​2482) (8693653)
  • eslint-plugin: [no-unused-vars] correct detection of unused vars in a declared module with export = (#​2505) (3d07a99)
  • eslint-plugin: [no-unused-vars] properly handle ambient declaration exports (#​2496) (4d3ce5f)
  • eslint-plugin: [no-use-before-define] false positive with jsx pragma reference (#​2503) (5afeeab), closes #​2502
  • eslint-plugin: [typedef] false positive for rest parameter with array destructuring (#​2441) (2ada5af)
  • eslint-plugin: handle missing message IDs in eslint v5/v6 (#​2461) (ffdfade)
  • scope-manager: add const as a global type variable (#​2499) (eb3f6e3)
  • scope-manager: correctly handle inferred types in nested type scopes (#​2497) (95f6bf4)
  • scope-manager: don't create references for intrinsic JSX elements (#​2504) (cdb9807)
  • scope-manager: fallback to lib 'esnext' or 'es5' when ecma version is unsupported (#​2474) (20a7dcc)
  • scope-manager: support rest function type parameters (#​2491) (9d8b4c4), closes #​2449
  • scope-manager: support tagged template string generic type parameters (#​2492) (a2686c0)
  • scope-manager: support type predicates (#​2493) (a40f54c), closes #​2462
  • scope-manager: treat type imports as both values and types (#​2494) (916e95a), closes #​2453
Features

4.0.1 (2020-08-31)

Bug Fixes

v4.0.1

Compare Source

Bug Fixes

v4.0.0

Compare Source

Please see the release notes for v4.0.0

Bug Fixes
  • eslint-plugin: [no-shadow] fix false-positive on enum declaration (#​2374) (9de669f)
  • eslint-plugin: [no-unused-vars] handle TSCallSignature (#​2336) (c70f54f)
  • correct decorator traversal for AssignmentPattern (#​2375) (d738fa4)
  • scope-manager: correct analysis of abstract class properties (#​2420) (cd84549)
  • typescript-estree: correct ChainExpression interaction with parentheses and non-nulls (#​2380) (762bc99)
Features
  • consume new scope analysis package (#​2039) (3be125d)
  • support ESTree optional chaining representation (#​2308) (e9d2ab6)
  • eslint-plugin: [ban-ts-comment] change default for ts-expect-error to allow-with-description (#​2351) (a3f163a), closes #​2146
  • eslint-plugin: [no-unnecessary-condition][strict-boolean-expressions] add option to make the rules error on files without strictNullChecks turned on (#​2345) (9273441)
  • eslint-plugin: [typedef] remove all defaults (#​2352) (a9cd6fb)
  • eslint-plugin: add consistent-type-imports rule (#​2367) (58b1c2d)
  • typescript-estree: switch to globby (#​2418) (3a7ec9b), closes #​2398
BREAKING CHANGES
  • typescript-estree: - removes the ability to supply a RegExp to projectFolderIgnoreList, and changes the meaning of the string value from a regex to a glob.

    • Removed decorators property from several Nodes that could never semantically have them (FunctionDeclaration, TSEnumDeclaration, and TSInterfaceDeclaration)
  • Removed AST_NODE_TYPES.Import. This is a minor breaking change as the node type that used this was removed ages ago.

  • eslint-plugin: Default rule options is a breaking change.

3.10.1 (2020-08-25)

Bug Fixes
  • eslint-plugin: [no-unnecessary-condition] correct regression with unary negations (#​2422) (d1f0887), closes #​2421

Renovate configuration

📅 Schedule: "on Saturday" (UTC).

🚦 Automerge: Disabled due to failing status checks.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added the type: maintenance Regular maintenance, like updating dependencies label Sep 5, 2020
@renovate renovate bot force-pushed the renovate/major-typescript-eslint-monorepo branch 4 times, most recently from fa16208 to ec0a7e2 Compare September 5, 2020 09:42
@mrdrogdrog mrdrogdrog force-pushed the renovate/major-typescript-eslint-monorepo branch 2 times, most recently from d062b0d to 3c8a6c8 Compare September 5, 2020 10:29
@mrdrogdrog
Copy link
Member

mrdrogdrog commented Sep 5, 2020

It seems like one of our eslint plugins isn't ready yet for the new eslint-version. This causes the build failure.

@renovate renovate bot force-pushed the renovate/major-typescript-eslint-monorepo branch 3 times, most recently from 522d04d to 025d34f Compare September 13, 2020 15:06
@renovate renovate bot force-pushed the renovate/major-typescript-eslint-monorepo branch 5 times, most recently from 2478edb to 5c64afc Compare September 19, 2020 18:39
@mrdrogdrog
Copy link
Member

I adjusted the package.json, because the new ESLint config preset contains the "no-use-before-define" rule. This rule breaks the linter, because the compontents import React.. and I don't know why, but eslint doesn't like that.

DerMolly
DerMolly previously approved these changes Sep 19, 2020
@mrdrogdrog
Copy link
Member

mrdrogdrog commented Sep 19, 2020

It seems like react-scripts depends on @typescript-eslint 2 and the problem I tried to solve was fixed in version 3. We should wait until facebook/create-react-app#9434 is released, so that react-scripts will depend on @typescript-eslint 4.

@mrdrogdrog mrdrogdrog removed the request for review from ErikMichelson September 19, 2020 20:02
@mrdrogdrog mrdrogdrog dismissed DerMolly’s stale review September 19, 2020 20:02

wait for further development

@renovate renovate bot force-pushed the renovate/major-typescript-eslint-monorepo branch 2 times, most recently from e823955 to d3a9aeb Compare September 28, 2020 17:13
@renovate renovate bot changed the title Update typescript-eslint monorepo to v4 (major) Update typescript-eslint monorepo (major) Sep 28, 2020
@renovate renovate bot force-pushed the renovate/major-typescript-eslint-monorepo branch from d3a9aeb to d78ea82 Compare September 28, 2020 17:44
@renovate renovate bot changed the title Update typescript-eslint monorepo (major) Update typescript-eslint monorepo to v4 (major) Sep 28, 2020
@DerMolly
Copy link
Member

DerMolly commented Oct 5, 2020

Just looked through the linked issue:
Apparently the problem will be solved with react-scripts 6. A preview of this version is already available on npm https://www.npmjs.com/package/eslint-config-react-app/v/6.0.0-next.98 for about two weeks now, but I guess it'll take some time til this get's released…

@renovate renovate bot force-pushed the renovate/major-typescript-eslint-monorepo branch from d78ea82 to 0b065a0 Compare October 5, 2020 17:23
@mrdrogdrog
Copy link
Member

Then we'll have to wait.

wait

@ErikMichelson ErikMichelson marked this pull request as draft October 9, 2020 17:20
@renovate renovate bot force-pushed the renovate/major-typescript-eslint-monorepo branch 2 times, most recently from c2e2fc7 to 6ac7f54 Compare October 19, 2020 17:15
@renovate renovate bot changed the title Update typescript-eslint monorepo to v4 (major) Update typescript-eslint monorepo (major) Oct 19, 2020
@renovate renovate bot force-pushed the renovate/major-typescript-eslint-monorepo branch from 6ac7f54 to 5d9a086 Compare October 19, 2020 17:36
@renovate renovate bot changed the title Update typescript-eslint monorepo (major) Update typescript-eslint monorepo to v4 (major) Oct 19, 2020
@renovate renovate bot changed the title Update typescript-eslint monorepo to v4 (major) Update typescript-eslint monorepo to v4 (major)- autoclosed Oct 25, 2020
@renovate renovate bot closed this Oct 25, 2020
@renovate renovate bot deleted the renovate/major-typescript-eslint-monorepo branch October 25, 2020 20:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: maintenance Regular maintenance, like updating dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants