Generate NuGet package during build #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't see why not. Even if we want to undo this in the future, it wouldn't be a breaking change. 👍 |
|
I always do it this way myself for my own packages. I have never found a downside. It removes the need for a separate |
|
Exactly, and we can take that section off from the README.md now, I suppose. |
|
Not a huge deal, but I've run into this dotnet/sdk#10335. |
|
Is the fix to remove the call to |
|
Yep. I'll update the README.md 👀 |
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How about generating a NuGet package as part of the build?
In general, it is useful to know if some change prevents the ability to create the NuGet package. More specifically, this helps test unreleased code. Of course it is possible to add a direct dependency on the project, but it is easier to obtain and share the NuGet package and depend on it after putting it in a local NuGet package source. In particular, this change would make it easier to test PR #251.