Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Rich Logger (Resolves #81) #84

Merged
merged 4 commits into from
Oct 2, 2020
Merged

Added Rich Logger (Resolves #81) #84

merged 4 commits into from
Oct 2, 2020

Conversation

ineelshah
Copy link
Contributor

'resolves #81 '
Solved the given issue, to the best of my knowledge.
Updated search.py, test_cli.py

Please let me know if I have missed something. I would be happy to solve it.

Checklist

  • My code is properly formatted using the latest black
  • I have added/updated tests if needed
  • I have tried running my code manually
  • I have checked for spelling errors

Description

'resolves #81 '
'closes #81 '
BEFORE:
image

AFTER:
image

tests/test_cli.py Outdated Show resolved Hide resolved
starcli/search.py Outdated Show resolved Hide resolved
starcli/search.py Outdated Show resolved Hide resolved
starcli/search.py Outdated Show resolved Hide resolved
Copy link
Owner

@hedyhli hedyhli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your PR, going to merge this

hedyhli added a commit that referenced this pull request Oct 2, 2020
Added Rich Logger (Resolves #81)
@hedyhli hedyhli merged commit da75955 into hedyhli:main Oct 2, 2020
@hedyhli
Copy link
Owner

hedyhli commented Oct 2, 2020

@allcontributors please add @ineelshah for code

@allcontributors
Copy link
Contributor

@hedythedev

I've put up a pull request to add @ineelshah! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better debug logging - Use rich.logging
2 participants