Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] 'color' command not working #4752

Closed
leo-sar opened this issue Nov 14, 2023 · 3 comments · Fixed by #4756
Closed

[BUG] 'color' command not working #4752

leo-sar opened this issue Nov 14, 2023 · 3 comments · Fixed by #4756

Comments

@leo-sar
Copy link
Contributor

leo-sar commented Nov 14, 2023

In level 4, the color command is introduced. However, it does not work.

level 4, drawing exercise:
color white
forward -80
color green
forward 50
color yellow
forward 50
color red
forward 50

image

I am using Chrome on a Windows computer.
@jpelay jpelay self-assigned this Nov 14, 2023
@jpelay
Copy link
Member

jpelay commented Nov 14, 2023

Thanks for pointing this out! I'll look into this.

@jpelay
Copy link
Member

jpelay commented Nov 14, 2023

Oops seems like @Felienne is already working on this in #4751

@jpelay jpelay removed their assignment Nov 14, 2023
@Felienne
Copy link
Member

Yes, I just heard from a teacher, will fix and deploy this tomorrow!

@jpelay jpelay mentioned this issue Nov 14, 2023
Merged
This was referenced Nov 14, 2023
Closed
Merged
@mergify mergify bot closed this as completed in #4756 Nov 16, 2023
mergify bot pushed a commit that referenced this issue Nov 16, 2023
@Felienne
[LANGUAGE, FIX] Fix non-en colors in lists and ask (#4756)
70cf3f9 
Reverts #4754. This is a redo of #4675, which fixed #3356 but caused #4752.

This has additional commits that also fix #4752.

**Original text from #4675:**

**Description**

Allows the use of Dutch (and other langs) names in a list, fixing  #3356. This new way of processing numbers to English at runtime also allows for using non-English colors in an ask:

<img width="1608" alt="image" src="https://github.com/hedyorg/hedy/assets/1003685/fa373815-47d5-4e68-b50b-d69404082c6f">

This PR:
<img width="1592" alt="image" src="https://github.com/hedyorg/hedy/assets/1003685/07d0f3ee-e8aa-4407-ad5d-0660c651cba8">

main:
<img width="1422" alt="image" src="https://github.com/hedyorg/hedy/assets/1003685/c7a2d2e5-7c33-48a7-9b63-ce9b0182d932">

**Fixes #3356**

**How to test**

I added a test about the list access, for the ask issue, check that the images above work for you also.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Hedy organization board
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[LANGUAGE, FIX] Fix non-en colors in lists and ask hedyorg/hedy
3 participants
@Felienne @jpelay @leo-sar