Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI, Language] Adds CodeMirror #4755

Merged
merged 134 commits into from
Nov 15, 2023
Merged

[UI, Language] Adds CodeMirror #4755

merged 134 commits into from
Nov 15, 2023

Conversation

jpelay
Copy link
Member

@jpelay jpelay commented Nov 14, 2023 •
edited by Felienne
Loading

Description

Adds CodeMirror as editor in Hedy. (Redo of #4479)

@jpelay
add code mirror and themes
4b1f83d
@jpelay
read only editors set up to be ace editor
b528d6a
@jpelay
advances in changing the editor height
88ddd96
@jpelay
add todo comment
ee38836
@jpelay
resizing the editor
1b0f129
@jpelay
add some more functions
363abb5
@jpelay
adds clearSelection method
853a909
@jpelay
adds event listener function
ee91c10
@jpelay
add trim trailing whitespace function again
37f9b27
@jpelay
functions for setting the contents and read mode of the editor
81f3c76
@jpelay
adds remove trailing whitespace function
5b36a4e
@jpelay
adding direction in the style of Code Mirror parent element
5ce010d
@jpelay
Merge branch 'main' of github.com:hedyorg/hedy into add-codemirror
c0c66a8
@jpelay
Merge branch 'main' of github.com:hedyorg/hedy into add-codemirror
56bbac0
@jpelay
adds stubble of markers functions
9b92b19
@jpelay
adds highlight error functionality
dd9d44b
@jpelay
change error styling and add clearErrors function
5f9da81
@jpelay
add mark for single word
0ac1d73
@jpelay
change some variable names
884ffb7
@jpelay
adding debugger decoration
41c1fce
@jpelay
Merge branch 'main' of github.com:hedyorg/hedy into add-codemirror
91ee2fd
@jpelay
move decorations to their own file
6c131ab
@jpelay
add deactivate line decoration
7440a28
@jpelay
delete unnecesary function from interface
ca96e00
@jpelay
use breakpoint gutter uin codemirror
f3b8b7b
@jpelay
delete unused method
d6cdfd0
@jpelay
remove breakpoints from interface
4e66eb5 
And add function to get the content from the lines that are active in the code
@jpelay
get active contents in app.ts
dd9c8ac
@jpelay
add functon to get active contents in code mirror
834cd1e
@jpelay
adadpt debugging file to code mirror
2d66098
jpelay and others added 24 commits November 13, 2023 12:14
@jpelay
better bash script for generating grammars
e816ef0
@jpelay
remove todo comment
327a549
@jpelay
method for skip faulty handler
f4c94fd
@jpelay
remove console logs
31c814a
@jpelay
ace editor 1-indexed
b47089a
@jpelay
proper tag type
b88e113
@jpelay
reduce repetion of style tags
1267e5a
@jpelay
remove unused interface
ba4d244
@jpelay
remove console log
100fff3
@jpelay
automatically generated parsers
539e6b7
@jpelay
Merge branch 'main' into add-codemirror
1366e85
@jpelay
fix int not being highlighted
ad45da3
@jpelay
Merge branch 'add-codemirror' of github.com:jpelay/hedy into add-code…
083447a 
…mirror
@jpelay
test for level 1 parser
971081c
@jpelay
Implement multi level tester
9cb0b70
@jpelay
fix single level tester
49d3277
@jpelay
Merge branch 'main' of github.com:hedyorg/hedy into add-codemirror
99594be
@jpelay
improve redabilty of level 1 tester and fix error tests
7008d64
@jpelay
tests level 2 and stub of level 6
1725bca
@jpelay
rename files
bfc4e33
@jpelay
adding default value for language in tester
b3d647c
@jpelay
error test for level 2
e52d943
@jpelay
fix to list
78186af
@jpelay
level 3 tests
588a610
@jpelay jpelay added the localization Issues that have to do with localizing the Hedy language and UI label Nov 14, 2023
@mergify mergify bot mentioned this pull request Nov 14, 2023
Merged
4 tasks
Felienne
Felienne approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@Felienne Felienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I have deployed the color revert, so we are good to go!!

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 15, 2023

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 5765281 into hedyorg:main Nov 15, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Felienne Felienne Felienne approved these changes

Assignees
No one assigned
Labels
localization Issues that have to do with localizing the Hedy language and UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpelay @Felienne