-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] allow adventures to be added to multiple levels #4793
Conversation
- extra checks
This reverts commit 6bf6b89.
Please don't mind the amount of commits! Most of which were a part of testing cypress, so see files changed for review! |
- go to public page of a user if exists.
Hi @hasan-sh! What is the status of this? I am trying to clean up the open PRs a bit. |
It's ready for review! |
Thanks! Can you address the conflicts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great @hasan-sh!!
Good question! I don't think we need to do something here in code though. If a teacher accidentally adds a "wrong" adventure, students will let them know soon enough! |
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Idea
In this PR, I'm converting how adventures relate to levels. Currently, an adventure can be added to one level only. The goal is to allow using adventures in different levels.
Fixes #3573
Questions and Concerns:
How to test?
customize-adventure
view