💻 hide all quizes/parsons and show tabs in levels #5156
Conversation
…levels based on these
There was a problem hiding this comment.
Hi @hasan-sh! Sorry for not reviewing it earlier! Everything works great, and I think this is a great idea, however there's something we must change: if a class already has a customization object and I enter the customization page again, then my class won't have any quizes. Can we find a way to automatically add parsons and quizzes to the customization objects that hasn't been touched previous to this PR? Like a migration.
@jpelay thanks for the reminder, i had a TODO in the code, but apparently i missed it! Does your IDE notify you about todos!? Now it should be ready to roll! |
|
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Actually no haha! I often write those down in my notebook or in the calender. If I do it in the code I tend to forget. |
Fixes #4655 Depends-On: #5156 <img width="1440" alt="Screenshot 2024-03-01 at 11 31 37" src="https://github.com/hedyorg/hedy/assets/48122190/8f04d20b-5095-4a93-a9a3-89628158a15c"> Start teaching goes to: - if not logged in: `signup?teacher=true` - if logged in as teacher: `for-teachers` - if logged in as student: `my-profile` In the future, we want it to be linked to #5183
Fixes #5155 Depends-On: #5156 Added a general "Go back" button to: `/customize-class` `/live-stats` `/customize-adventure` `/grid-overview` and `/for-teachers/class` <img width="1440" alt="Screenshot 2024-02-29 at 14 34 15" src="https://github.com/hedyorg/hedy/assets/48122190/1e397636-61eb-4257-843e-e8cae421627e">
Fixes #5155 Depends-On: #5156 Added a general "Go back" button to: `/customize-class` `/live-stats` `/customize-adventure` `/grid-overview` and `/for-teachers/class` <img width="1440" alt="Screenshot 2024-02-29 at 14 34 15" src="https://github.com/hedyorg/hedy/assets/48122190/1e397636-61eb-4257-843e-e8cae421627e">
**Problem** Related to #5156  The feature actually works. However, it only works if the teacher has logged in and at least visited the customize-class page. This is because there's a migration step that I added which basically adds the quizzes/puzzles to the list of adventures if they were not hidden before. The problem that this PR solves is related to the scenario in which a student is logged in and interacts with a class while their teacher has not refreshed the customize-class page: Thus the migration was not done yet at this point, hence the students then would not see the quizzes/puzzles. _Why didn't we figure it out earlier not during testing nor reviewing?_ This is mainly because **we tested it while relying on** the _previewing class_ feature. This feature, supposidely, would allow a teacher to exactly simulate what students see and how they interact with the related class. But apparently that's not the case, since the preview feature is simply coplying the customization class and "allowing the user to merely see that class". **How to test?** - in your `dev_database.json` file, remove the quiz/puzzle manually from at least the first level of the `sorted_adventures` of your class (e.g., CLASS1) - then log in as a student and the quiz/puzzle should be readded and shown to you, iff. the quiz/puzzle was not disabled
Fixes #5141
Key points
Something went missing when i added the key translations for #5026 (check 6ee2c4f#diff-852046eb47f474139974edf5e69ed9758f9fde82e1432c49d772b89aef354b37), so I'm adding them here.
How to test?