🪲 Check for programs with empty string as adventure id #5208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Felienne
reviewed
Mar 5, 2024
app.py
Outdated
| for program in all_programs: | ||
| if 'adventure_name' in program and program['adventure_name'] not in adventure_names: | ||
| if 'adventure_name' in program and program['adventure_name'] != '' and\ |
There was a problem hiding this comment.
Suggested change
| if 'adventure_name' in program and program['adventure_name'] != '' and\ | |
| if 'adventure_name' in program and program['adventure_name'] and\ |
I think this formulation is slightly more Pythonic?
Felienne
approved these changes
Mar 5, 2024
|
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some old programs present the challenge of having an empty string in their
adventure_namefield. Luckily, this doesn't seem to happen anymore, as I checked the DB and in production only programs from around 2022 present this issue.How to test
idand put an emtpy string in theadventure_namefield. On main, it should crash, using this branch, the programs page should be shown normally.Here's an example for the user
student1:{ "session": "fac24066d19f4fd8ac44508ac4a7fdae", "date": 1709241804445, "lang": "en", "version": "DEV", "level": 1, "code": "ask What's your name?\necho so your name is\nask What's your name?\necho so your name isask What's your name?\necho so your name isask What's your name?\necho so your name isask What's your name?\necho so your name isask What's your name?\necho so your name is", "name": "adventure1 test test", "username": "student1", "adventure_name": "", "id": "ididididididididididi", "username_level": "student1-1", "public_profile": null }