Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📜 Cleaning up level 12 up and also adds new adventure in level 16 #5264

Merged
merged 11 commits into from
Mar 15, 2024

Conversation

MarleenGilsing
Copy link
Collaborator

@MarleenGilsing MarleenGilsing commented Mar 14, 2024

Cleans up level 12 and up

Fixes #3507
Fixes #4514
Fixes #5048

Adds songs 2 adventure in level 16 in all languages.

@MarleenGilsing MarleenGilsing added the Weblate-lock Used to mark pull requests that might conflict with Weblate and must be merged in calm Weblate times label Mar 14, 2024
@MarleenGilsing MarleenGilsing changed the title 📜 Cleaning up level 12 - ? also adds new adventure in level 16 📜 Cleaning up level 12 up and also adds new adventure in level 16 Mar 14, 2024
@MarleenGilsing MarleenGilsing marked this pull request as ready for review March 14, 2024 12:40
@Felienne
Copy link
Member

Thanks @MarleenGilsing! Thanks for fixing the blackjack code, but the code example still remains very long and a bit scary.

I am not sure what the best solution is, because I do like the idea of having kids reorganize code! Can we maybe split it into steps, or add a few "gaps" that kids have to fill in? (we can also discuss this together next week!)

Copy link
Contributor

mergify bot commented Mar 15, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 6588f1f into main Mar 15, 2024
12 checks passed
@mergify mergify bot deleted the Big-cleanup-3 branch March 15, 2024 09:02
Copy link
Contributor

mergify bot commented Mar 15, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Weblate-lock Used to mark pull requests that might conflict with Weblate and must be merged in calm Weblate times
Projects
None yet
2 participants