Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪲 fix preview adventure #5363

Merged
merged 4 commits into from
Apr 4, 2024
Merged

🪲 fix preview adventure #5363

merged 4 commits into from
Apr 4, 2024

Conversation

hasan-sh
Copy link
Collaborator

@hasan-sh hasan-sh commented Apr 3, 2024

Fixes #5360

How to test?

  • try previewing adventure1 and adventure3 with the teacher1 account
  • you could also create adventures with different levels and test that too!

@Felienne Felienne changed the title fix preview adv fix preview adventure Apr 4, 2024
@Felienne Felienne changed the title fix preview adventure 🪲 fix preview adventure Apr 4, 2024
@@ -0,0 +1,22 @@
import {loginForTeacher} from '../../tools/login/login.js'

describe('Is able to preview adventures', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's add tests when stuff is broken!!

@hasan-sh hasan-sh marked this pull request as ready for review April 4, 2024 09:42
Copy link
Collaborator

@boryanagoncharenko boryanagoncharenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works smoothly!

Copy link
Contributor

mergify bot commented Apr 4, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit f1ba387 into main Apr 4, 2024
12 checks passed
@mergify mergify bot deleted the fix-preview-adv branch April 4, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🪲 preview adventure isn't always working!
3 participants