Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Refactor cypress tests (part 1) #5393

Merged
merged 15 commits into from
Apr 17, 2024
Merged

🧹 Refactor cypress tests (part 1) #5393

merged 15 commits into from
Apr 17, 2024

Conversation

Annelein
Copy link
Collaborator

@Annelein Annelein commented Apr 10, 2024

Fixes the following tests for #4027 :

  • admin page
  • explore program page
  • feedback

@Annelein Annelein requested a review from jpelay April 10, 2024 13:00
@Annelein
Copy link
Collaborator Author

Annelein commented Apr 10, 2024

@jpelay is this what it should look like for example? Then I can start going through all tests and implement these changes!

And why was #4032 closed?

@Annelein
Copy link
Collaborator Author

@jpelay @Felienne would it make sense to separate this issue into a few PR's? Otherwise it will be huge and then once in a while I can just change a few tests again.

@jpelay
Copy link
Member

jpelay commented Apr 17, 2024

@jpelay @Felienne would it make sense to separate this issue into a few PR's? Otherwise it will be huge and then once in a while I can just change a few tests again.

Sure!

@Annelein Annelein marked this pull request as ready for review April 17, 2024 12:06
@Annelein Annelein mentioned this pull request Apr 17, 2024
19 tasks
@Annelein Annelein changed the title 🧹 Refactor cypress tests 🧹 Refactor cypress tests (part 1) Apr 17, 2024
@Annelein
Copy link
Collaborator Author

@jpelay then it's ready to be reviewed :)) Think it would be great if you could do it asap to avoid conflicts because it has changes in a lot of different places

Copy link
Member

@Felienne Felienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!!

Copy link
Contributor

mergify bot commented Apr 17, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit c64fb12 into main Apr 17, 2024
12 checks passed
@mergify mergify bot deleted the refactor-cypress-tests branch April 17, 2024 14:14
Copy link
Contributor

mergify bot commented Apr 17, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants