Skip to content
This repository has been archived by the owner on Oct 17, 2024. It is now read-only.

Add FNV and Percentile operators, and testing #102

Merged
merged 25 commits into from
Apr 3, 2019

Conversation

tealeg
Copy link
Contributor

@tealeg tealeg commented Apr 2, 2019

Fixes #99
Fixes #100

This PR backports the Percentile operator to release-v0.6. I also bought FNV along for the ride - I don't know how we'd use it outside the Percentile function, but its an operator on v0.7 so I made it equlivalent.

@tealeg tealeg added the enhancement New feature or request label Apr 2, 2019
@tealeg tealeg self-assigned this Apr 2, 2019
@tealeg tealeg requested review from asdine and yaziine April 2, 2019 10:44
Copy link

@yaziine yaziine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@asdine asdine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

rule/expr_test.go Outdated Show resolved Hide resolved
Copy link

@yaziine yaziine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to add the operator to json.go as I did here.

@tealeg
Copy link
Contributor Author

tealeg commented Apr 2, 2019

You forgot to add the operator to json.go as I did here.

Excellent point @Yassinee ! 🆙

rule/json.go Outdated Show resolved Hide resolved
@tealeg tealeg requested a review from yaziine April 3, 2019 07:44
@tealeg tealeg merged commit 21dca80 into release-v0.6 Apr 3, 2019
@tealeg tealeg deleted the percentile-operator branch April 3, 2019 12:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants