Skip to content
This repository has been archived by the owner on Sep 9, 2023. It is now read-only.

Node.js 12 support #5

Closed
ai opened this issue Apr 23, 2019 · 7 comments
Closed

Node.js 12 support #5

ai opened this issue Apr 23, 2019 · 7 comments

Comments

@ai
Copy link

ai commented Apr 23, 2019

After updating to Node.js 12 I start to get the error:

$ jsdoc -d docs/ *.js react/*.js
/home/travis/build/ai/storeon/node_modules/requizzle/lib/requizzle.js:45
	if (lookupPaths[0] === targetPath && lookupPaths[1].length === 0) {
	               ^
TypeError: Cannot read property '0' of null
    at isNativeModule (/home/travis/build/ai/storeon/node_modules/requizzle/lib/requizzle.js:45:17)
    at Requizzle.requizzle (/home/travis/build/ai/storeon/node_modules/requizzle/lib/requizzle.js:82:6)
    at infectProxy (/home/travis/build/ai/storeon/node_modules/requizzle/lib/loader.js:82:28)
    at Module.targetModule.require (/home/travis/build/ai/storeon/node_modules/requizzle/lib/loader.js:101:11)
    at require (internal/modules/cjs/helpers.js:16:16)
    at Object.<anonymous> (/home/travis/build/ai/storeon/node_modules/jsdoc/lib/jsdoc/fs.js:7:10)
    at Module._compile (internal/modules/cjs/loader.js:759:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:770:10)
    at Module.load (internal/modules/cjs/loader.js:628:32)
    at Object.load (/home/travis/build/ai/storeon/node_modules/requizzle/lib/loader.js:112:15)

https://travis-ci.org/ai/storeon/builds/523619135

Hope it is not a JSDoc error since JSDoc has no maintenance anymore.

RandomByte added a commit to SAP/ui5-logger that referenced this issue Apr 23, 2019
The current version of a JSDoc dependency is not compatible with node 12. Also see: hegemonic/requizzle#5
RandomByte added a commit to SAP/ui5-fs that referenced this issue Apr 23, 2019
The current version of a JSDoc dependency is not compatible with node 12. Also see: hegemonic/requizzle#5
RandomByte added a commit to SAP/ui5-builder that referenced this issue Apr 23, 2019
The current version of a JSDoc dependency is not compatible with node 12. Also see: hegemonic/requizzle#5
RandomByte added a commit to SAP/ui5-project that referenced this issue Apr 23, 2019
The current version of a JSDoc dependency is not compatible with node 12. Also see: hegemonic/requizzle#5
RandomByte added a commit to SAP/ui5-server that referenced this issue Apr 23, 2019
The current version of a JSDoc dependency is not compatible with node 12. Also see: hegemonic/requizzle#5
RandomByte added a commit to SAP/ui5-cli that referenced this issue Apr 23, 2019
The current version of a JSDoc dependency is not compatible with node 12. Also see: hegemonic/requizzle#5
RandomByte added a commit to SAP/ui5-cli that referenced this issue Apr 23, 2019
The current version of a JSDoc dependency is not compatible with node 12. Also see: hegemonic/requizzle#5
RandomByte added a commit to SAP/ui5-logger that referenced this issue Apr 23, 2019
The current version of a JSDoc dependency is not compatible with node 12. Also see: hegemonic/requizzle#5
RandomByte added a commit to SAP/ui5-fs that referenced this issue Apr 23, 2019
The current version of a JSDoc dependency is not compatible with node 12. Also see: hegemonic/requizzle#5
RandomByte added a commit to SAP/ui5-project that referenced this issue Apr 23, 2019
The current version of a JSDoc dependency is not compatible with node 12. Also see: hegemonic/requizzle#5
RandomByte added a commit to SAP/ui5-server that referenced this issue Apr 23, 2019
The current version of a JSDoc dependency is not compatible with node 12. Also see: hegemonic/requizzle#5
RandomByte added a commit to SAP/ui5-builder that referenced this issue Apr 23, 2019
The current version of a JSDoc dependency is not compatible with node 12. Also see: hegemonic/requizzle#5
@jgravois
Copy link

it looks like #4 already attempts to address this.

@ai
Copy link
Author

ai commented Apr 24, 2019

@hegemonic seems like we found a way to fix this issue

@ghost
Copy link

ghost commented Apr 25, 2019

@ai:Is this fixed or anything to fix? Would you mind sharing your suggestion? :)

@ai
Copy link
Author

ai commented Apr 25, 2019

@Maledong #4 is a PR, which probably will fix this issue. It is not merged yet.

@ghost
Copy link

ghost commented Apr 26, 2019

Thanks!

@75lb
Copy link

75lb commented Apr 29, 2019

jsdoc2md is currently broken in node v12 until this issue is resolved.

@hegemonic
Copy link
Owner

Fixed by #4. Apologies for the delay.

I'll release a new version of this module soon, followed by a new version of JSDoc. I'm swamped right now, so it'll probably take a few days. In the meantime, thanks for your patience.

devtomtom pushed a commit to SAP/ui5-builder that referenced this issue Jun 17, 2019
The current version of a JSDoc dependency is not compatible with node 12. Also see: hegemonic/requizzle#5
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants